Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade AppAuth-iOS to 1.0.0 #338

Merged
merged 6 commits into from
Jun 28, 2019
Merged

Upgrade AppAuth-iOS to 1.0.0 #338

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aa9819e
Upgrade AppAuth-iOS to 1.0.0
Jun 27, 2019
b0eb174
Add AppAuth dependency in the root level Podspec
Jun 28, 2019
2f535ba
Remove duplicate podspec
Jun 28, 2019
e78587f
Keep the root level podspec only
Jun 28, 2019
3f36c2f
Rename root level podspec to match library name
Jun 28, 2019
ad05491
Update pod install instructions
Jun 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,9 +241,9 @@ AppAuth supports three options for dependency management.
With [CocoaPods](https://guides.cocoapods.org/using/getting-started.html), add the following line to
your `Podfile`:

pod 'AppAuth', '>= 0.94'
pod 'AppAuth', '1.0'

Then run `pod install`. Note that version 0.94 is the first of the library to support iOS 11.
Then run `pod install`.
Copy link

@thymikee thymikee Jun 28, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, all instructions about linking on both paltforms are obsolete in RN 0.60 if the library works with autolinking. All you need to document now is:

  1. running pod install after adding the dep
  2. how to use with Carthage or anything that is not CocoaPods or manual link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I'll update the instructions. Thanks for all your help on this!


2. **Carthage**

Expand Down
4 changes: 2 additions & 2 deletions ios/RNAppAuth.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ + (nullable NSString *)codeChallengeS256ForVerifier:(NSString *)codeVerifier {
// generates the code_challenge per spec https://tools.ietf.org/html/rfc7636#section-4.2
// code_challenge = BASE64URL-ENCODE(SHA256(ASCII(code_verifier)))
// NB. the ASCII conversion on the code_verifier entropy was done at time of generation.
NSData *sha265Verifier = [OIDTokenUtilities sha265:codeVerifier];
return [OIDTokenUtilities encodeBase64urlNoPadding:sha265Verifier];
NSData *sha256Verifier = [OIDTokenUtilities sha256:codeVerifier];
return [OIDTokenUtilities encodeBase64urlNoPadding:sha256Verifier];
}

/*
Expand Down
2 changes: 1 addition & 1 deletion ios/RNAppAuth.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ Pod::Spec.new do |s|
s.requires_arc = true

s.dependency "React"
s.dependency "AppAuth", "0.94.0"
s.dependency "AppAuth", "1.0.0"
end
19 changes: 0 additions & 19 deletions react-native-app-auth.podspec
View file
Open in desktop

This file was deleted.