Optimized stringMap calculation #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boygirl
reviewed
Dec 20, 2018
|
|
||
| const initialMemo = { x: [], y: [] }; | ||
| const combine = (memo, datum) => ({ | ||
| x: datum.x ? memo.x.concat(datum.x) : memo.x, |
There was a problem hiding this comment.
I think these should be datum.x !== undefined ?
There was a problem hiding this comment.
Though maybe this is unnecessary since the case where these would be empty strings is a bit contrived.
There was a problem hiding this comment.
!== undefined is better, I'll change that.
|
sorry about the timing. We just added prettier. Would you mind rebasing: |
|
Happy New Year! These changes are desirable. Do you have a moment to rebase? |
MxFr
force-pushed
the
optimize-stringMap-calculation
branch
from
88bc033
to
5258110
Compare
|
Sorry for being so unresponsive, but I was on a vacation over chrismas. The rebase to prettier is now done. |
|
🎉 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the optimization I spoke of in a recent issue (#1207).
Instead of iterating (including formatting, cleaning et.) the data twice and extracing a different property each time, the data is iterated once and both properties are extracted.
To achive this I had to adapt
reduceChildrento allow different kinds of reduce functions instead of accumulating every result in an array, otherwise I would have ended up with an array of objects containing thexandyproperties, which would have required another iteration for unwrapping.