Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alter reduceChildren to fix parent events regression #1227

Merged
merged 2 commits into from
Jan 9, 2019
Merged

alter reduceChildren to fix parent events regression #1227

merged 2 commits into from
Jan 9, 2019

Conversation

boygirl
Copy link
Contributor

@boygirl boygirl commented Jan 9, 2019

@MxFr
I noticed a small regression causing parent events to use the incorrect eventKey. It was caused by the additional reduce in reduceChildren introduced in #1211

I altered reduceChildren and moved the additional work into the custom combine method used when calculating the string map.

@boygirl boygirl merged commit 8955aef into master Jan 9, 2019
@boygirl boygirl deleted the bug/parent-events-use-incorrect-key branch January 9, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@boygirl