Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from danielgindi:master #8

Open
wants to merge 313 commits into
base: master
Choose a base branch
from

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 7, 2020

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

pmairoldi and others added 30 commits October 21, 2018 19:02
Make NSUIAccessibilityElement initializer public.
Fix wrong assignment to axisMaxLabels property
fix #3656
* fixed barRectCaculation

* fixed offset calculation

* Fix the  mess caused by the setting the min&min value of the y-axis by error :
Just simply swap their values

* Fix the mess caused by the setting the min&min value of the y-axis by error

* Revert "Fix the mess caused by the setting the min&min value of the y-axis by error"

This reverts commit 526a73a.

* Fix the mess caused by the setting the min&min value of the y-axis by error

* update offset calculation

* update code style

* update code style

* update offset calculation

* keep barRect calculation untouched

try to simply the calculation. keep barRect calculation untouched

* After the correction of min and max ,  they should be assigned back to  _axisMinimum and _axisMaximum

* add demo for bar chart unit test

* update unit test

* revert last commit

* update unit test

* make sure max is greater than min &
turnoff record mode for barchartest

* add new UT and fix some issues.

1. add more bar chart UT
2. code style fix
3. manually add chart.notifyDataSetChanged() - some old UT and new ones forget to call this method, leading the test images to be wrong.

Notice:
some test images diff shows slight pixel shift, not sure why, but both old and new image seems drawing correctly

* update tvOS images

* update tolerance to 1% & more swift-y

* update tvOS images, removing "Description Label", (not rendered anymore)

changing tolerance will trigger "Description Label" detection

* update iOS test images, "Description Label" no longer rendered.

* fixed offset calculation in some cases.
moved those codes into the for loop. because the offset of each bar may be different.
(detail in comments)

* Update Source/Charts/Renderers/BarChartRenderer.swift

Co-Authored-By: potato04 <[email protected]>
* #3578 Add missing properties to copy(with:) methods

* Add NSCopying conformance
Update document to latest format
DataSets for line chart have lineCap property which is supposed to be applied to the chart line. But it was applied only if dataSet is drawn in linear/stepped mode. This commit makes lineCap work for any existing mode.
Fix legend offset bug for horizontal bar chart (Fixes #3301)
…CapForAll

Fix applying lineCap value for line chart data sets (Fixes #3739)
Replace a confusing sentence with a clear one. Fix grammatical errors.
Fix condition that is checked before `chartTranslated` delegate method call
Feature - ChartView Pan Ended Delegate Call
…sion and Sequence

Sequence conformance simplifies for-in loops
Looking forward to when data types conforming to Collection, RangeExpression conformance by XBounds allows for slicing of the collections further simplifying algorithms on data/datasets.
Add Collection conformances to ChartDataSet types
* Multiple colors for valueline (Fixes #3480)

This change adds a flag matchValueLineColorToPieSlice to PieChartDataSet and IPieChartDataSet protocol.
When enabled, valuelines will have the same color as slices they attached to.
matchValueLineColorToPieSlice is set to false by default, so colors won't be changed in old projects that use Charts.

* Changed variable name from matchValueLineColorToPieSlice to valueLineAutoColor

* Changed variable name from valueLineAutoColor to useValueColorForLine

* Changed variable name from valueLineAutoColor to useValueColorForLine

* fix code style

fix code style

* Changed check for useValueColorForLine with suggested

* fix code style

* Added name DrawLine: to do{} section
Removed arbitrary setter access to `entries` to encourage use of `Collection` mechanics
Added `replaceEntries`
…that is called when Animator stops animating
Brendan Kirchner and others added 30 commits May 30, 2023 10:38
bump min version to 13 for ios project
Fix Xcode 14.3 import warnings
remove swift-algorithms package in favor of manully importing needed …
* added labelRotationAngle to ChartLimitLine

* added limit line label rotation tests

* fixed the code style
labelLineRotated_Width/Height got the same position

* generated test images for apple TV

* add snapshots on x64 arch for tvOS and iOS

---------

Co-authored-by: Xuan <[email protected]>
This reverts commit dc24c39.
Process completed with exit code 1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⤵️ pull merge-conflict Resolve conflicts manually
Projects
None yet
Development

Successfully merging this pull request may close these issues.