Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Portable/oWatcom formatting #829

Merged
merged 13 commits into from
Dec 7, 2023
Merged

Conversation

Skptak
Copy link
Member

@Skptak Skptak commented Oct 10, 2023

Description

Revert the formatting on oWatcom ports

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Skptak Skptak requested a review from a team as a code owner October 10, 2023 23:12
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db5df4b) 93.78% compared to head (38d0a81) 93.78%.
Report is 1 commits behind head on main.

❗ Current head 38d0a81 differs from pull request most recent head afc0703. Consider uploading reports for the commit afc0703 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #829   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files           6        6           
  Lines        3184     3184           
  Branches      885      885           
=======================================
  Hits         2986     2986           
  Misses         91       91           
  Partials      107      107           
Flag Coverage Δ
unittests 93.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Skptak Skptak mentioned this pull request Nov 8, 2023
2 tasks
Copy link
Member

@chinglee-iot chinglee-iot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared with commit before #768
d6bccb1 | 2023-09-05 | Gaurav-Aggarwal-AWS | Fix heap address calculation issue (#781)

d6bccb1...Skptak:FreeRTOS-Kernel:fixWatcomFormatting

  • INDENT-OFF/ON comments are removed
  • configTICK_TYPE_WIDTH_IN_BITS is wrongly reverted.

@@ -29,11 +29,9 @@
#ifndef PORTMACRO_H
#define PORTMACRO_H

/* *INDENT-OFF* */
#ifdef __cplusplus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INDENT-OFF/ON comments is removed.

portable/oWatcom/16BitDOS/Flsh186/portmacro.h Show resolved Hide resolved
portable/oWatcom/16BitDOS/Flsh186/portmacro.h Show resolved Hide resolved
@@ -29,11 +29,9 @@
#ifndef PORTMACRO_H
#define PORTMACRO_H

/* *INDENT-OFF* */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INDENT suggestion.

portable/oWatcom/16BitDOS/PC/portmacro.h Show resolved Hide resolved
portable/oWatcom/16BitDOS/PC/portmacro.h Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aggarg aggarg merged commit bcf7bda into FreeRTOS:main Dec 7, 2023
15 checks passed
@Skptak Skptak deleted the fixWatcomFormatting branch December 19, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants