Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel community page #1568

Merged
merged 104 commits into from
Mar 4, 2023
Merged

Channel community page #1568

merged 104 commits into from
Mar 4, 2023

Conversation

GilgusMaximus
Copy link
Contributor

@GilgusMaximus GilgusMaximus commented Aug 6, 2021 •
edited by ChunkyProgrammer
Loading

Channel community page

Pull Request Type
Please select what type of pull request this is:

  • Feature Implementation

Description
This patch adds the community page tab to all channels. Items that can be displayed:

Not supported:

  • shared post

Screenshots (if appropriate)

Text
image

Image
image

Video
image

MultiImage
image

Poll
image

Playlist
image

Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested?
Has been tested extensively for all kinds of channels.

Desktop (please complete the following information):

  • OS: Windows
  • OS Version: 10
  • FreeTube version: v13.2 0.18.0

Additional context
Still todo as discussed: Include playlist css into standard playlist css and check whether playlist is displayed in list or standalone mode

GilgusMaximus and others added 28 commits April 14, 2021 18:29
@GilgusMaximus
Comunity page strings, Communtiy tab, Community initial API call
1df9f73 
Added:
1) Community page strings - the first few strings are now available
2) Community tab - A clickable tab is now displayed on channel pages
3) Community initial API call - on loading the page, the initial access
@GilgusMaximus
Comunity page strings, Communtiy tab, Community initial API call
034fc4c 
Added:
1) Community page strings - the first few strings are now available
2) Community tab - A clickable tab is now displayed on channel pages
3) Community initial API call - on loading the page, the initial access
@GilgusMaximus
Data returning added
736fca5
@GilgusMaximus
Merge
bce1b5b
@GilgusMaximus
Comunity page strings, Communtiy tab, Community initial API call
d452ceb 
Added:
1) Community page strings - the first few strings are now available
2) Community tab - A clickable tab is now displayed on channel pages
3) Community initial API call - on loading the page, the initial access
@GilgusMaximus
Data returning added
13ad637
@GilgusMaximus
Merge branch 'communityPage' of github.com:GilgusMaximus/FreeTube int…
134159b 
…o communityPage

Merge
@GilgusMaximus
Images are now displayed in the community tab
ebfe1c8
@GilgusMaximus
Comunity page strings, Communtiy tab, Community initial API call
fc747c5 
Added:
1) Community page strings - the first few strings are now available
2) Community tab - A clickable tab is now displayed on channel pages
3) Community initial API call - on loading the page, the initial access
@GilgusMaximus
Data returning added
5ab0a84
@GilgusMaximus
Images are now displayed in the community tab
9d6ba3b
@GilgusMaximus
Added primitive video display
59903db
@GilgusMaximus
Current changes
089b450
@GilgusMaximus
Current changes Merge
157db72
@GilgusMaximus
Added preston's change with the ftcard and started on some layout basics
f7cb1de
@GilgusMaximus
Created Community Post Component and added fetch more button + functi…
d28af79 
…onality
@GilgusMaximus
Fixed problem with videothumbnails not loading and adjusted their hei…
1b012b1 
…ght to 100% in the ft-list sass file
@GilgusMaximus
Added poll and ft-list-video to the community page
5bfec73
@GilgusMaximus
Added author name placeholder (missing in module), the published date…
5d1485d 
…, the likes and dislikes as well as comment counts to posts. Additionally scaling of images was added
@GilgusMaximus
Added basis for community page playlists
2b65ffa
@GilgusMaximus
Finalized a setup for playlists when wide enough
63af918
@GilgusMaximus
Merge
3b62b75
@GilgusMaximus
Fix for missing key in custom list
e8b2d83
@GilgusMaximus
Added publish date translation
f7b8075
@PrestonN
Merge branch 'development' into communityPage
f64d225
@PrestonN
Merge branch 'development' into communityPage
7275896
@PrestonN
Merge branch 'development' into communityPage
fa0430c
@PrestonN
Merge branch 'development' into communityPage
be4130b
@peepo5
Copy link
Contributor

peepo5 commented Aug 20, 2021

Looks good. If it still looks the same as the picture provided, upper padding would look nice.

@github-actions github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Mar 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ChunkyProgrammer ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 3, 2023
PikachuEXE
PikachuEXE previously approved these changes Mar 3, 2023
View reviewed changes
@absidue
Copy link
Member

absidue commented Mar 3, 2023

The getBestQualityImage function needs to behave differently depending on the backend, for the local API the best quality image is the first one in the array, for the Invidious API it's the last one in the array.

@absidue
Copy link
Member

absidue commented Mar 3, 2023

Also if you visit a channel the default tab/tab in the url isn't selected anymore with this pull request.
unselected_tab

@ChunkyProgrammer
Copy link
Member

@absidue should be fixed

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Shared posts are now supported by youtube.js LuanRT/YouTube.js#331

Only LuanRT/YouTube.js#334 needs to be merged so it can be fixed here

@PikachuEXE
Copy link
Collaborator

@efb4f5ff-1298-471a-8973-3d47447115dc Wait for 3.2.0?

@ChunkyProgrammer
Copy link
Member

Imo shared posts can be added in a follow up PR this pr has been sitting for a while and is already pretty big as is (we should probably open an issue for shared posts on invdious as well)

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 4, 2023 •
edited
Loading

Ok will create issue for it. @PikachuEXE use thunderApproveShock

PikachuEXE
PikachuEXE approved these changes Mar 4, 2023
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@PrestonN PrestonN merged commit 4ef2f70 into FreeTubeApp:development Mar 4, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 4, 2023
This was referenced Apr 14, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer left review comments

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@absidue absidue absidue approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@kommunarr kommunarr kommunarr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@GilgusMaximus @peepo5 @ChunkyProgrammer @efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE @absidue @kommunarr @PrestonN