-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community: parse reply count and polls #3635
Merged
SamantazFox
merged 4 commits into
iv-org:master
from
ChunkyProgrammer:feat/parse-reply-count-and-polls
Mar 12, 2023
Merged
Community: parse reply count and polls #3635
SamantazFox
merged 4 commits into
iv-org:master
from
ChunkyProgrammer:feat/parse-reply-count-and-polls
Mar 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: syeopite <[email protected]>
ChunkyProgrammer
requested review from
SamantazFox
and removed request for
a team
February 15, 2023 04:12
SamantazFox
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I've made some recommendations below
SamantazFox
added
need-testing
This feature needs to be deployed and tested to see if it's working, and doesn't break something
module:channels
labels
Mar 1, 2023
Co-Authored-By: Samantaz Fox <[email protected]>
ChunkyProgrammer
force-pushed
the
feat/parse-reply-count-and-polls
branch
from
March 2, 2023 04:56
9318079
to
4a14713
Compare
1 task
Tested on https://test.invidious.io -> works fine! |
SamantazFox
added
ready
and removed
need-testing
This feature needs to be deployed and tested to see if it's working, and doesn't break something
labels
Mar 12, 2023
Thanks for your PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR parses the reply count for community posts
and parses the poll type for community posts (including an optional image)
Poll: