Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community: parse reply count and polls #3635

Merged

Conversation

ChunkyProgrammer
Copy link
Contributor

This PR parses the reply count for community posts
and parses the poll type for community posts (including an optional image)

Poll:

{
    type: "poll",
    totalVotes: number,
    choices: [
      {
         text: string
         image?: [
             {
               url: string,
               width: number,
               height: number
             }
         ]
      }
    ]
}

Copy link
Member

@SamantazFox SamantazFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I've made some recommendations below

src/invidious/channels/community.cr Show resolved Hide resolved
src/invidious/channels/community.cr Outdated Show resolved Hide resolved
src/invidious/channels/community.cr Outdated Show resolved Hide resolved
@SamantazFox SamantazFox added need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something module:channels labels Mar 1, 2023
@SamantazFox
Copy link
Member

Tested on https://test.invidious.io -> works fine!

@SamantazFox SamantazFox added ready and removed need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something labels Mar 12, 2023
@SamantazFox SamantazFox merged commit 5c633ad into iv-org:master Mar 12, 2023
@SamantazFox
Copy link
Member

Thanks for your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants