Update custom image request to handle error event

[PikachuEXE]

Update custom image request to handle error event

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

Improves #2498

Description

Javascript errors are thrown in main process (not renderer process) so the annoying dialog sometimes appears for network errors, e.g. #2498 (comment)
This PR updates the FT imagecache implementation to catch request error event and log it to console, preventing the annoying dialog to appear

Doc for request error event:
https://www.electronjs.org/docs/latest/api/client-request#event-error

Screenshots

Dialog example

Testing

• Download custom build (with this PR included)
• Enable Replace HTTP Cache
• Use like normal and ensure no dialog appears

Desktop

• OS: MacOS
• OS Version: 12.6.1
• FreeTube version: fc5be5b

Additional context

I tested this for a week before submitting this PR

[absidue]

Personally I've never seen that network error dialog, however as the code looks good and everyone else seems to be getting these errors, I'll happily approve this PR.