Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade electron from 22.x to 27.x and replace deprecated protocol.registerBufferProtocol #3967

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Upgrade electron from 22.x to 27.x and replace deprecated protocol.registerBufferProtocol #3967

merged 2 commits into from
Oct 20, 2023

Conversation

PikachuEXE
Copy link
Collaborator

@PikachuEXE PikachuEXE commented Aug 29, 2023 •
edited by efb4f5ff-1298-471a-8973-3d47447115dc
Loading

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Closes #3960
Closes #2831
Closes #4008

Description

#3960 plus replace deprecated protocol.registerBufferProtocol
https://www.electronjs.org/docs/latest/breaking-changes#deprecated-protocolregisterinterceptbufferstringstreamfilehttpprotocol

Screenshots

N/A

Testing

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

@github-actions github-actions bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Aug 29, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 29, 2023 01:23
@PikachuEXE
Copy link
Collaborator Author

Hide whitespaces for easier review

ChunkyProgrammer
ChunkyProgrammer reviewed Aug 29, 2023
View reviewed changes
src/main/index.js Outdated Show resolved Hide resolved
@PikachuEXE
Copy link
Collaborator Author

PikachuEXE commented Aug 29, 2023 •
edited
Loading

Strange, I pushed my commit but not shown here
image

Edit: Tried force push, still not updated
image

@github-actions github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 6, 2023
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@absidue pls review when you're available :)

@PikachuEXE PikachuEXE mentioned this pull request Sep 8, 2023
Merged
@absidue
Copy link
Member

absidue commented Sep 8, 2023

We should get one of the people from #3953 to test this, before we merge it, as Electron 26 is what caused the problems for them.

@github-actions github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc linked an issue Oct 11, 2023 that may be closed by this pull request
[Bug]: Blank Page When Watching Videos #4097
Closed
6 tasks
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Oct 16, 2023 •
edited
Loading

@PikachuEXE could u update this to 27.0.0?

#4167

@PikachuEXE PikachuEXE changed the title Upgrade electron from 22.x to 26.x and replace deprecated protocol.registerBufferProtocol Upgrade electron from 22.x to 27.x and replace deprecated protocol.registerBufferProtocol Oct 16, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@PikachuEXE
Copy link
Collaborator Author

Done

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Not sure if we have to make additional changes for the breaking changes
https://github.com/electron/electron/releases/tag/v27.0.0

@PikachuEXE
Copy link
Collaborator Author

Do we use systemPreferences or ipcRenderer.sendTo()?
I guess not

@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

From my searches the breaking changes in v27.0.0 do not matter to us

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ChunkyProgrammer ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 17, 2023
Closed
5 tasks
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Nice Closes #2831! Ill be adding it to the PR body.

@FreeTubeBot FreeTubeBot merged commit 4043961 into FreeTubeApp:development Oct 20, 2023
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 20, 2023
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Oct 21, 2023
@PikachuEXE
Merge branch 'development' into feature/playlist-2023-05
bf09e46 
* development:
  Bump stefanzweifel/git-auto-commit-action from 4 to 5 (FreeTubeApp#4124)
  Upgrade electron from 22.x to 27.x and replace deprecated `protocol.registerBufferProtocol` (FreeTubeApp#3967)
  ! Fix single playlist view item index style (FreeTubeApp#4179)
  Fix proxy settings test (FreeTubeApp#4192)
  Translated using Weblate (German)
  fix typos in src/main/index.js comments (FreeTubeApp#4180)
  Translated using Weblate (English (United Kingdom))
  Translated using Weblate (Indonesian)
  Translated using Weblate (Italian)
  Remove be.yaml file (FreeTubeApp#4176)
@ryneeverett ryneeverett mentioned this pull request Oct 29, 2023
Closed
@PikachuEXE PikachuEXE deleted the upgrade/electron-26 branch January 10, 2024 00:43
OothecaPickle added a commit to OothecaPickle/FreeTube that referenced this pull request Sep 4, 2024
@OothecaPickle
Revert "Upgrade electron from 22.x to 27.x and replace deprecated `pr…
2ec07fc 
…otocol.registerBufferProtocol` (FreeTubeApp#3967)"

This reverts commit 4043961.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@absidue absidue absidue approved these changes

@kommunarr kommunarr Awaiting requested review from kommunarr

Assignees
No one assigned
Labels
PR: dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Blank Page When Watching Videos [Bug]: Doesn't respect system theme in GNOME
6 participants
@PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @absidue @LAURAilway @ChunkyProgrammer @FreeTubeBot