Use smaller Vue esm runtime build #3271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
approved these changes
Mar 6, 2023
PikachuEXE
approved these changes
Mar 7, 2023
| @@ -1,18 +1,16 @@ | |||
| import Vue from 'vue' | |||
| import { defineComponent } from 'vue' | |||
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 7, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Mar 15, 2023
* development: (106 commits) Translated using Weblate (Swedish) Translated using Weblate (Swedish) Translated using Weblate (Swedish) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Swedish) Translated using Weblate (Slovak) Translated using Weblate (Galician) Setting loudness to default volume in new videos (FreeTubeApp#3203) Translated using Weblate (Bulgarian) Translated using Weblate (Russian) Skip the exists check for the databases, as stat does it anyway (FreeTubeApp#3272) Use smaller Vue esm runtime build (FreeTubeApp#3271) Translated using Weblate (Italian) Bump eslint-config-prettier from 8.6.0 to 8.7.0 (FreeTubeApp#3269) Bump lefthook from 1.3.1 to 1.3.3 (FreeTubeApp#3268) Bump rimraf from 4.1.2 to 4.3.0 (FreeTubeApp#3264) Bump video.js from 7.21.2 to 7.21.3 (FreeTubeApp#3265) Bump eslint-plugin-unicorn from 45.0.2 to 46.0.0 (FreeTubeApp#3266) Translated using Weblate (Georgian) Translated using Weblate (Lithuanian) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use smaller Vue esm runtime build
Pull Request Type
Description
As we use vue-loader our {component}.vue templates get compiled at build time, which means we don't need to compile them at runtime. Currently we are using a the full Vue build, which contains both the runtime and compiler, switching to the runtime only build allows us to shave off a chunk of our bundle (0.04MB for the Electron build and 0.03MB for the web build).
https://v2.vuejs.org/v2/guide/installation.html#Runtime-Compiler-vs-Runtime-only
Screenshots
renderer:
web:
Testing
Test various functionality to check that it still works.
Desktop