Setting loudness to default volume in new videos

[predystopic-dev]

Title

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

#3125
Partially fixes above (Pika: updated to NOT close the issue when this is merged)
With latest commit, the issue should be fixed completely and not partially. (Edit: predystopic-dev)

Description

When user mutes a video and opens new video, it will open with volume set to default volume set by user in settings. However, if video was not muted, and new video is opened, then volume will remain at it's original value.

Screenshots

n/a

Testing

Code is self-explanatory and it didn't affect anything else.

Desktop

• OS: Windows
• OS Version: Windows 11 22H2
• FreeTube version: development build

Additional context

Instead of starting the new video muted, and settings it to default volume on unmuting, I made volume be set directly to default volume for new videos if previous video was muted by user. If someone can point me in the right direction, I can attempt to fix this issue as suggested in #3125 but I was unable to find the function responsible for settings the value back to 100% on unmuting, hence tried to partially fix the issue.

[absidue]

video.js keeps track of the volume and muted settings on the video player separately, so I think the better approach would be to store the muted and volume properties separately in the session and set both on the player when it gets created. That way it will properly keep the volume and muted status across videos.

[absidue]

Do we actually need the default volume? I feel like it might be confusing or unexpected behaviour from a users perspective if the player sometimes uses the volume from the last video and other times uses the default volume.
I was thinking something more along the lines of this, that way both the muted state and the volume get carried over from one video to the next:

diff --git a/src/renderer/components/ft-video-player/ft-video-player.js b/src/renderer/components/ft-video-player/ft-video-player.js
index 332ceb13..bdaa74cc 100644
--- a/src/renderer/components/ft-video-player/ft-video-player.js
+++ b/src/renderer/components/ft-video-player/ft-video-player.js
@@ -89,6 +89,7 @@ export default defineComponent({
       id: '',
       powerSaveBlocker: null,
       volume: 1,
+      muted: false,
       player: null,
       useDash: false,
       useHls: false,
@@ -315,11 +316,19 @@ export default defineComponent({
   },
   mounted: function () {
     const volume = sessionStorage.getItem('volume')
+    const muted = sessionStorage.getItem('muted')
 
     if (volume !== null) {
       this.volume = volume
     }
 
+    if (muted !== null) {
+      // sessionStorage only returns strings
+      // any string that isn't empty is considered truthy by the javascript runtime
+      // so we need to explicitly check for a string value of true, as the string "false" would be considered true as well
+      this.muted = muted === 'true'
+    }
+
     this.dataSetup.playbackRates = this.playbackRates
 
     this.createFullWindowButton()
@@ -400,6 +409,7 @@ export default defineComponent({
         })
 
         this.player.volume(this.volume)
+        this.player.muted(this.muted)
         this.player.playbackRate(this.defaultPlayback)
         this.player.textTrackSettings.setValues(this.defaultCaptionSettings)
         // Remove big play button
@@ -712,10 +722,11 @@ export default defineComponent({
     },
 
     updateVolume: function (_event) {
-      // 0 means muted
       // https://docs.videojs.com/html5#volume
-      const volume = this.player.muted() ? 0 : this.player.volume()
+      const volume = this.player.volume()
+      const muted = this.player.muted()
       sessionStorage.setItem('volume', volume)
+      sessionStorage.setItem('muted', muted)
     },
 
     mouseScrollVolume: function (event) {

[predystopic-dev]

Do we actually need the default volume? I feel like it might be confusing or unexpected behaviour from a users perspective

Actually, I was going for the fix as suggested in bug report. But yes, now I think this approach would be more suitable. from user's perspective. What should I do now? (Sorry I am a bit new to contributing on github in general), should I make these changes and commit them? or have you done that already in which case I reckon I should close this PR?

[ChunkyProgrammer]

Actually, I was going for the fix as suggested in bug report. But yes, now I think this approach would be more suitable. from user's perspective. What should I do now? (Sorry I am a bit new to contributing on github in general), should I make these changes and commit them? or have you done that already in which case I reckon I should close this PR?

You should make these changes and commit them 🙂

[predystopic-dev]

Sorry I made a mistake and ran some wrong commands.
I'll make changes and recommit thank you

[PikachuEXE]

Since this is declared to partially fixes #3125
I have updated the description to avoid closing #3125 automatically

[PikachuEXE]

Default volume set to 70%

A) Not muted

• View a video, set volume to ~10%
• View another video, volume remains at ~10% (OK)

B) Muted

• View a video, set volume to ~10%, set as muted
• View another video, volume remains muted (OK)
• Unmute, volume jumps to 100% instead of default volume 70% (Not OK)

[predystopic-dev]

• View a video, set volume to ~10%, set as muted

• View another video, volume remains muted (OK)

• Unmute, volume jumps to 100% instead of default volume 70% (Not OK)

How are you muting it? If we directly click on mute icon or press 'm' to mute/unmute then volume should be set at previously muted volume however if we drag the volume slider to 0 then volume in sessionStorage is set to 0 and if you unmute now, it will set volume to 100%

[PikachuEXE]

I only mute it by pressing the mute icon (not even 'm')
I use 'm' this time and it's the same result

[PikachuEXE]

@toby63 Problem is there can be a use case of listening to a list of videos known to need larger volume value
Having to adjust volume every time (due to volume set higher than default volume) is quite annoying (if only using previous volume when <= default volume)

[absidue]

@toby63 navigating from an unmuted video to another unmuted video, should keep the volume of the previous video, that's how it behaved before this pull request and that behaviour should really be kept, changing that now is going to annoy more people than it helps.

[toby63]

@toby63 Problem is there can be a use case of listening to a list of videos known to need larger volume value Having to adjust volume every time (due to volume set higher than default volume) is quite annoying (if only using previous volume when <= default volume)

Just in theory (see also below): Could this not be solved by identifying list videos?

@toby63 navigating from an unmuted video to another unmuted video, should keep the volume of the previous video, that's how it behaved before this pull request and that behaviour should really be kept, changing that now is going to annoy more people than it helps.

Ok, I see that this is a situation where a design decision has to be made.
But what about an option in the settings?

[ChunkyProgrammer]

Something like this iv-org/invidious#3600 could potentially be added but imo it's a different feature request and should be discussed in a different issue

[predystopic-dev]

Are there any issues with commit that need be fixed now?

[efb4f5ff-1298-471a-8973-3d47447115dc]

Im a bit confused by reading all the comments. Could u explain to me what the expected behavior is with a few example scenarios

[predystopic-dev]

Could u explain to me what the expected behavior is with a few example scenarios

Assume default volume set to 80% in user settings.

1. Not muted

- View a video, set volume to 20%

- View another video -> volume remains at 20%

2. Muted via mute button

- View a video, set volume to 20%. 

- Mute by clicking on mute button or pressing appropriate key on keyboard.

- View another video, volume remains muted 

- On unmuting volume jumps to 20% 

3. Muting via dragging volume slider to 0.

- View a video at any volume, but drag the slider to 0.

- View another video -> volume remains muted

- On unmuting, volume jumps to 80% (user default)  

[PikachuEXE]

@efb4f5ff-1298-471a-8973-3d47447115dc ?

[efb4f5ff-1298-471a-8973-3d47447115dc]

Uumm is there a reason for not closing #3125