Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: galoy chart #1193

Merged
merged 24 commits into from
Jul 27, 2022
Merged

refactor: galoy chart #1193

merged 24 commits into from
Jul 27, 2022

Conversation

sandipndev
Copy link
Member

This PR refactors the templates and brings out a good structure of default values.yml.

Inspired by Concourse Helm Charts pattern.

@sandipndev sandipndev marked this pull request as ready for review July 19, 2022 07:17
@sandipndev
Copy link
Member Author

In order to preserve the spaces and inline comments of values.yaml we need to find a solution where yq doesn't remove them: https://github.com/GaloyMoney/galoy/blob/main/ci/tasks/bump-image-digest.sh#L12-L15

@sandipndev
Copy link
Member Author

For both the image refs to be updated, GaloyMoney/blink#1485 should go through

@sandipndev sandipndev merged commit 8c9a899 into main Jul 27, 2022
@sandipndev sandipndev deleted the galoy-chart-refactor branch July 27, 2022 13:12
sandipndev added a commit that referenced this pull request Jul 27, 2022
sandipndev added a commit that referenced this pull request Jul 27, 2022
* Revert "chore: renamed api to galoy-api (#1296)"

This reverts commit 97f1bc3.

* Revert "fix: dont create secrets for testflight (#1295)"

This reverts commit 07aee59.

* Revert "refactor: galoy chart (#1193)"

This reverts commit 8c9a899.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants