-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add nextcloud compatibility and firebase optionality #978
Conversation
thanks for your contribution @zoop-btc ! I didn't dive into the code, but making firebase a non mandatory dependency is very useful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code involving mongo backup tools can be removed as we have now shifted to using a dedicated docker image for the mongo backup cronjob which has the dependency preinstalled
Thank you @krtk6160 this looks even better now since the mongodb-tools value can be completely removed :) |
I have moved the trigger outside of the deployment loop @bodymindarts as per your suggestion. charts/charts/galoy/values.yaml Lines 46 to 56 in d2b61bf
This format would be followed by the other galoy deployments. I can do it for the others as well in a separate PR. |
@sandipndev iirc you too were refactoring the galoy chart. Does that have any overlap/conflict with the changes here? Might make sense to sync with @zoop-btc to avoid duplicated efforts or conflicts |
@krtk6160 nope, I was doing the secrets so it's not in the scope of this PR at all. |
updated branch - no breaking changes found - ready for review |
@zoop-btc There's a significant refactor of the galoy chart that @sandipndev is doing in #1193. It has some amount of overlap with this PR, so those parts will no longer be necessary once we rebase this PR following the merge of #1193. P.S. No need to rebase now, #1193 is still WIP. |
@krtk6160 Understood, I'll wait for it to be merged and then adjust this PR accordingly. Thank you for the heads-up. |
*refactor: make all google firebase credentials optional *refactor: make dropbox and google cloud credentials optional *refactor: consolidate backup mechanism variables
closing this, I will split it into two pull requests, one for nextcloud and the other to make firebase optional - I think factoring trigger out of the deployment was too big of a scope |
@zoop-btc the newer refactored charts have been merged. It now allows you to add in another |
I would like to propose these changes so it'll be possible to use Nextcloud as a backup mechanism.
This also introduces a new structure to the values. It makes sense to consolidate them as backup since they're both used for the mongodb as well as the scb backup. This is what I came up with but please feel free to give input!
If a user wants to deploy the charts right now without having access to dropbox/google cloud/firebase then it will fail since the secrets referenced don't exist. The only solution I saw was to encapsulate them in if statements and use firebaseaccountneeded as well as the enabled values above. I made it so it'll still reflect the defaults by disabling nextcloud. However disabling firebase will turn off the daily notifications, which anybody deciding to forego google needs to be made aware of. Maybe I will tackle that later on.
Are there any other issues which not using google at all could create? (I have not noticed any in my test environment.)
This pull request coincides with one for the galoy repo .
The secret for nexcloud should look like this and needs to be manually applied like the others:
The host should point to the full url of the nextcloud webdav target like this:
https://myserver.com/remote.php/dav/files/myuser/backupfolder
thank you kindly for the consideration
ps: sorry adding so many checks to the mongodb backup script, but better safe than sorry