Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): cached notificationsCount should only grow over time #231

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

mattyg
Copy link
Collaborator

@mattyg mattyg commented Sep 9, 2023

Cached notifications count should never shrink (i.e. if an authority has a smaller count than a prior queried authority, ignore it).

Improves #189

…shrink (i.e. if an authority has a different count than a prior queried authority)
@mattyg mattyg requested a review from jost-s September 9, 2023 21:33
Copy link
Collaborator

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The number of the badge grows over time or remains equal as expected when reopening the web app. However, it always goes down to 7 when I go to the notifications page.

image image

Is that expected?

@mattyg
Copy link
Collaborator Author

mattyg commented Sep 11, 2023

The number of the badge grows over time or remains equal as expected when reopening the web app. However, it always goes down to 7 when I go to the notifications page.

Is that expected?

In theory the number by 1 every time a previously unseen notification comes into the viewport. Have you scroll down to the end of the list of notifications?

Copy link
Collaborator

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes sense.

@mattyg mattyg merged commit a9bbb0f into main Sep 11, 2023
1 of 2 checks passed
@mattyg mattyg deleted the fix/notifications-count-only-grows branch September 11, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants