Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the documentation of Figure.shift_origin() #536

Merged
merged 4 commits into from
Jul 19, 2020
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Jul 18, 2020

Description of proposed changes

  • Fix a broken link
  • Add a note that the function can't be used as the fisrt plotting command.

Address #514.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

- Fix a broken link
- Add a note that the function can't be used as the fisrt plotting command.
@seisman seisman requested a review from weiji14 July 18, 2020 04:10
@seisman seisman added the documentation Improvements or additions to documentation label Jul 18, 2020
@seisman seisman added this to the 0.2.x milestone Jul 18, 2020
@vercel vercel bot temporarily deployed to Preview July 18, 2020 04:15 Inactive
@seisman seisman merged commit 6df6214 into master Jul 19, 2020
@seisman seisman deleted the shift-origin-doc branch July 19, 2020 21:17
weiji14 added a commit that referenced this pull request Sep 2, 2020
weiji14 added a commit that referenced this pull request Sep 2, 2020
* Remove note on shift_origin added in #536
* Remove xfails for put_strings added in #520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants