Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the required minimum GMT version to 6.1.1 #577

Merged
merged 3 commits into from
Sep 2, 2020
Merged

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Sep 2, 2020

Description of proposed changes

Bumps gmt from 6.1.0 to 6.1.1.

TODO:

  • Bump the required minimum GMT version to 6.1.1
  • Remove pytest xfails that were set to previous 6.1.0 version
  • Remove compatibility codes for GMT 6.1.0 (if any)
  • etc

Issues marked upstream that are resolved in GMT 6.1.1 will be handled in separate Pull Requests.

Supersedes #507

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Sep 2, 2020
@weiji14 weiji14 added this to the 0.2.x milestone Sep 2, 2020
@weiji14 weiji14 requested a review from a team September 2, 2020 22:35
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some tests marked as "xfail".

@pytest.mark.xfail(
condition=gmt_version < Version("6.1.1"),
reason="GMT_Put_Strings only works for GMT 6.1.1 and above",
)

Remove these "xfail" markers?

Also update this one:

assert Version(lib.get_default("API_VERSION")) >= Version("6.1.0")

@weiji14
Copy link
Member Author

weiji14 commented Sep 2, 2020

Good catch, thanks @seisman! Let me know if you find any other loose ends, I feel like there's a lot of them lying around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants