Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #5719] Coding style standard #5720

Merged
merged 1 commit into from
Feb 18, 2020
Merged

[Fixes #5719] Coding style standard #5720

merged 1 commit into from
Feb 18, 2020

Conversation

frafra
Copy link
Contributor

@frafra frafra commented Feb 18, 2020

Add pre-commit and black

Checklist

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there are explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Feb 18, 2020
@frafra frafra linked an issue Feb 18, 2020 that may be closed by this pull request
@frafra
Copy link
Contributor Author

frafra commented Feb 18, 2020

Black configuration has been set in order to match the one specified for flake8 in setup.cfg.

This PR do not require to wait for Travis CI to pass.

@afabiani afabiani added this to the 3.0 milestone Feb 18, 2020
@afabiani afabiani merged commit 559da07 into master Feb 18, 2020
@afabiani afabiani deleted the pre-commit branch February 18, 2020 16:00
@afabiani afabiani changed the title Add pre-commit and black [Fixes #5719] Coding style standard Feb 18, 2020
This was referenced Feb 20, 2020
@frafra frafra mentioned this pull request Mar 1, 2020
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coding style standard
2 participants