flake8 updates

[travislbrundage]

Fixing remaining files which had flake8 complaints.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

• Confirm you have read the contribution guidelines
• You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
• Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

• There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
• The issue connected to the PR must have Labels and Milestone assigned
• PR for bug fixes and small new features are presented as a single commit
• Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
• New unit tests have been added covering the changes, unless there are explanation on why the tests are not necessary/implemented
• This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
• This PR passes the QA checks: flake8 geonode
• Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

[lgtm-com]

This pull request fixes 4 alerts when merging 89dcac39573b7e76dd9f47ff17717af1f993f156 into 622b8b5 - view on LGTM.com

fixed alerts:

• 3 for Unused import
• 1 for Unused local variable

[codecov]

Codecov Report

Merging #5767 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5767   +/-   ##
=======================================
  Coverage   58.20%   58.20%           
=======================================
  Files         172      172           
  Lines       19461    19461           
  Branches     3209     3209           
=======================================
  Hits        11327    11327           
  Misses       7118     7118           
  Partials     1016     1016           

[lgtm-com]

This pull request fixes 4 alerts when merging ec3c86c2ed0291aabc5d97d73035b45db060afc0 into 216f7da - view on LGTM.com

fixed alerts:

• 3 for Unused import
• 1 for Unused local variable

[afabiani]

Failing SPC GeoNode local tests

[lgtm-com]

This pull request fixes 4 alerts when merging 80a07af6233e744d04279b81e2a261ebab88e5b8 into c241909 - view on LGTM.com

fixed alerts:

• 3 for Unused import
• 1 for Unused local variable

[frafra]

@travislbrundage Just for your information: #5720

[travislbrundage]

I made some updates but I am not sure how to run the spcgeonode local tests, sorry if I am missing something obvious. Does that just mean the docker doesn't build properly? I adjusted my changes to preserve the way things were done before in the spcgeonode file, so it should be functionally identical now.

Updating to fix the file conflicts now too.

[t-book]

hi @travislbrundage docs have been removed from master see: #5629
to resolve the conflict I think you just have to delete docs/conf.py hope this helps

[lgtm-com]

This pull request fixes 4 alerts when merging 8d6e681 into 690c446 - view on LGTM.com

fixed alerts:

• 3 for Unused import
• 1 for Unused local variable