Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP 8.1 #18

Merged
merged 12 commits into from
Mar 15, 2023
Merged

Support PHP 8.1 #18

merged 12 commits into from
Mar 15, 2023

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Mar 1, 2023

No description provided.

@paul-m paul-m marked this pull request as draft March 1, 2023 00:41
@paul-m
Copy link
Contributor Author

paul-m commented Mar 1, 2023

Still a WIP because it requires this change: fmizzell/maquina#6

@paul-m
Copy link
Contributor Author

paul-m commented Mar 5, 2023 •
edited
Loading

Still needs codeclimate project ID in the CI pipeline.

@paul-m
Copy link
Contributor Author

paul-m commented Mar 6, 2023

Currently depends on fmizzell/maquina:dev-master. It would be great to have a release to constrain to.

@paul-m paul-m marked this pull request as ready for review March 15, 2023 00:01
@dafeder dafeder merged commit fde3028 into master Mar 15, 2023
@dafeder dafeder deleted the support-php81 branch March 15, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dafeder dafeder dafeder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paul-m @dafeder