Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for PHP 8.1 #6

Merged
merged 4 commits into from
Mar 2, 2023
Merged

Prepare for PHP 8.1 #6

merged 4 commits into from
Mar 2, 2023

Conversation

paul-m
Copy link
Collaborator

@paul-m paul-m commented Feb 24, 2023

This PR is part of an initiative to make sure the dependencies of DKAN are compatible with PHP 8.1.

This PR does the following, as a minor refresh to ensure testability into the near future:

  • Update maximum PHPUnit version to <10, which has breaking changes.
  • Update bugatino/phpcs-git-pre-commit and squizlabs/php_codesniffer to less restrictive constraints, preferring stable versions.
  • Adds tooling and associated Composer scripts to facilitate local development.
  • Changes for PSR-2 coding standards.
  • Test classes now have setUp() method signatures to match the superclass.
  • Use of #[\ReturnTypeWillChange] annotation to support jsonSerialize() methods.

@fmizzell
Copy link
Owner

fmizzell commented Mar 2, 2023

Awesome... Thank you so much for all this work!

@fmizzell fmizzell merged commit c969d1f into fmizzell:master Mar 2, 2023
@paul-m
Copy link
Collaborator Author

paul-m commented Mar 2, 2023

🎉 thanks!

@paul-m
Copy link
Collaborator Author

paul-m commented Mar 2, 2023

It looks like the master builds are failing at the checkout step. Maybe you need to add a deploy key for circleCI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants