-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3369] video thumbnails compose #4096
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…droid into feature/3369-video-thumbnails-compose
…droid into feature/3369-video-thumbnails-core
… Images and Video and its accompanying composables.
…diaGalleryPreviewActivity` and receives results from it instead of `ImagePreviewActivity`
…droid into feature/3369-video-thumbnails-compose � Conflicts: � CHANGELOG.md � stream-chat-android-client/api/stream-chat-android-client.api � stream-chat-android-client/src/main/java/io/getstream/chat/android/client/ChatClient.kt � stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api/ChatApi.kt � stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/MoshiChatApi.kt � stream-chat-android-client/src/main/java/io/getstream/chat/android/client/channel/ChannelClient.kt � stream-chat-android-client/src/main/java/io/getstream/chat/android/client/models/UploadedFile.kt � stream-chat-android-client/src/main/java/io/getstream/chat/android/client/uploader/FileUploader.kt � stream-chat-android-client/src/main/java/io/getstream/chat/android/client/uploader/StreamFileUploader.kt � stream-chat-android-client/src/test/java/io/getstream/chat/android/client/uploader/StreamFileUploaderTest.kt � stream-chat-android-docs/src/main/java/io/getstream/chat/docs/java/client/helpers/MyFileUploader.java � stream-chat-android-docs/src/main/kotlin/io/getstream/chat/docs/kotlin/client/helpers/MyFileUploader.kt � stream-chat-android-state/src/main/java/io/getstream/chat/android/offline/message/attachments/internal/AttachmentUploader.kt � stream-chat-android-state/src/test/java/io/getstream/chat/android/offline/channel/controller/attachment/AttachmentUploaderTests.kt � stream-chat-android-state/src/test/java/io/getstream/chat/android/offline/channel/controller/attachment/UploadAttachmentsIntegrationTests.kt
… number of previewd thumbnails, including odd numbers.
…me specific grid spacing for media preview
…reen and implement retry procedure when reconnecting after having a failed load due to being offline.
… track that in real time in the gallery so it is pointless
… track that in real time in the gallery so it is pointless
filbabic
reviewed
Sep 8, 2022
...main/java/io/getstream/chat/android/compose/ui/attachments/content/MediaAttachmentContent.kt
Outdated
Show resolved
Hide resolved
filbabic
reviewed
Sep 8, 2022
...main/java/io/getstream/chat/android/compose/ui/attachments/content/MediaAttachmentContent.kt
Outdated
Show resolved
Hide resolved
filbabic
reviewed
Sep 8, 2022
...main/java/io/getstream/chat/android/compose/ui/attachments/content/MediaAttachmentContent.kt
Outdated
Show resolved
Hide resolved
filbabic
reviewed
Sep 8, 2022
...va/io/getstream/chat/android/compose/ui/attachments/content/MediaAttachmentPreviewContent.kt
Outdated
Show resolved
Hide resolved
filbabic
reviewed
Sep 8, 2022
...va/io/getstream/chat/android/compose/ui/attachments/content/MediaAttachmentPreviewContent.kt
Outdated
Show resolved
Hide resolved
filbabic
reviewed
Sep 8, 2022
...va/io/getstream/chat/android/compose/ui/attachments/content/MediaAttachmentPreviewContent.kt
Outdated
Show resolved
Hide resolved
filbabic
reviewed
Sep 8, 2022
...va/io/getstream/chat/android/compose/ui/attachments/content/MediaAttachmentPreviewContent.kt
Outdated
Show resolved
Hide resolved
filbabic
reviewed
Sep 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☑️Reviewer Checklist
- Compose sample runs & works
- UI Changes correct (before & after images)
- Bugs validated (bugfixes)
- New feature tested and works
- Release notes and docs clearly describe changes
- All code we touched has new or updated KDocs
This is certainly one of the best improvements to the UI part of Compose we've had in a long time and will bring lots of value to our users!
Overall, amazing job - I did leave some comments, so please clean them up and then we can merge!
…t` as requested in the PR review
…droid into feature/3369-video-thumbnails-compose � Conflicts: � DEPRECATIONS.md � stream-chat-android-compose/api/stream-chat-android-compose.api � stream-chat-android-compose/detekt-baseline.xml � stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/attachments/StreamAttachmentFactories.kt � stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/theme/StreamDimens.kt
…O dispatcher for writing files to cache.
filbabic
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Closes the compose part of #3369
🛠 Implementation details
Implemented a new gallery including offline capabilitie sand preview content.
🎨 UI Changes
Add relevant screenshots
Going from offline mode to online mode
before_message_list.mp4
after_message_list.mp4
before_gallery.mp4
galery_after.mp4
🧪 Testing
Since this PR is quite large (apologies), the recommendation is to first do the practical testing part before reading any code.
Test Scenario A: List Offline Capabilities
Expected: Images should load automatically when connection is regained
Test Scenario B: Gallery Offline Capabilities
Expected: Images should load automatically when connection is regained
Test Scenario C: Message List
Expected: The play button should be loaded only above videos. Both videos and images should be displayed properly.
Test Scenario D: Gallery
There are a few things to test here.
Due to the way
VideoPlayer
is made and the fact that it's actually just aView
, it's difficult to make it work as seamless as we would normally like.Test Scenario E: Customizing
MediaAttachmentFactory
Use the patch to customize MediaAttachmentFactory
Test Scenario F: Disabling video thumbnails
Use the patch to disable video thumbnails
Test Scenario G: Testing out the ability to independently change the size of Video, Image and group previews in
ChatTheme.dimens
Use the patch to apply independent sizing
☑️Contributor Checklist
General
develop
branchCode & documentation
☑️Reviewer Checklist
🎉 GIF