-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3369] Video thumbnails UI components (MessageList) #4158
Merged
MarinTolic
merged 32 commits into
develop
from
feature/3369-video-thumbnails-ui-components
Oct 18, 2022
Merged
[3369] Video thumbnails UI components (MessageList) #4158
MarinTolic
merged 32 commits into
develop
from
feature/3369-video-thumbnails-ui-components
Oct 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to `MediaAttachmentViewHolder`
MarinTolic
commented
Sep 14, 2022
...tream/chat/android/ui/message/list/adapter/viewholder/internal/MediaAttachmentsViewHolder.kt
Show resolved
Hide resolved
MarinTolic
commented
Sep 14, 2022
...m-chat-android-ui-components/src/main/res/layout/stream_ui_item_message_media_attachment.xml
Outdated
Show resolved
Hide resolved
MarinTolic
changed the title
Feature/3369 video thumbnails UI components
[3369] Video thumbnails UI components
Oct 7, 2022
…e to the inability to gain the relevant information at every possible point
…e to the inability to gain the relevant information at every possible point
MarinTolic
changed the title
[3369] Video thumbnails UI components
[3369] Video thumbnails UI components [MessageList]
Oct 7, 2022
MarinTolic
changed the title
[3369] Video thumbnails UI components [MessageList]
[3369] Video thumbnails UI components (MessageList)
Oct 7, 2022
MarinTolic
commented
Oct 10, 2022
...io/getstream/chat/android/ui/message/list/adapter/view/internal/MediaAttachmentsGroupView.kt
Show resolved
Hide resolved
…droid into feature/3369-video-thumbnails-ui-components � Conflicts: � stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/message/list/options/message/MessageOptionsDialogFragment.kt
TGazica
suggested changes
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☑️Reviewer Checklist
- UI Components sample runs & works
- UI Changes correct (before & after images)
- New feature tested and works
- Release notes and docs clearly describe changes
- All code we touched has new or updated KDocs
Works and looks good, left a few comments regarding formatting and kdocs, nothing major.
...src/main/kotlin/io/getstream/chat/android/ui/message/list/adapter/MessageListItemViewType.kt
Outdated
Show resolved
Hide resolved
...otlin/io/getstream/chat/android/ui/message/list/adapter/view/internal/MediaAttachmentView.kt
Outdated
Show resolved
Hide resolved
...io/getstream/chat/android/ui/message/list/adapter/view/internal/MediaAttachmentsGroupView.kt
Outdated
Show resolved
Hide resolved
...stream/chat/android/ui/message/list/adapter/viewholder/decorator/internal/AvatarDecorator.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Tomislav Gazica <[email protected]>
…-components' into feature/3369-video-thumbnails-ui-components
Co-authored-by: Tomislav Gazica <[email protected]>
…-components' into feature/3369-video-thumbnails-ui-components
…droid into feature/3369-video-thumbnails-ui-components � Conflicts: � CHANGELOG.md � stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/TransformStyle.kt
TGazica
approved these changes
Oct 17, 2022
…droid into feature/3369-video-thumbnails-ui-components � Conflicts: � CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR implements the Message List part of the video thumbnails effort, the gallery part will arrive in a separate PR.
🛠 Implementation details
Reworked the image attachment ViewHolder and its child elements in order to display both image and video attachments.
🎨 UI Changes
🧪 Testing
Test A:
Expectation: Everything should be rendered correctly with images and video being rendered as previewable attachments while other types will be rendered as file attachments.
Test B:
Provide the patch summary here
☑️Contributor Checklist
General
develop
branchCode & documentation
☑️Reviewer Checklist
🎉 GIF