-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3369] video thumbnails UI components gallery #4283
Merged
MarinTolic
merged 65 commits into
develop
from
feature/3369-video-thumbnails-ui-components-gallery
Oct 20, 2022
Merged
[3369] video thumbnails UI components gallery #4283
MarinTolic
merged 65 commits into
develop
from
feature/3369-video-thumbnails-ui-components-gallery
Oct 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to `MediaAttachmentViewHolder`
…droid into feature/3369-video-thumbnails-ui-components � Conflicts: � CHANGELOG.md � DEPRECATIONS.md
…droid into feature/3369-video-thumbnails-ui-components
…ttachments without fixed dimensions
…e to the inability to gain the relevant information at every possible point
…e to the inability to gain the relevant information at every possible point
…ttachment gallery
…droid into feature/3369-video-thumbnails-ui-components � Conflicts: � stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/message/list/options/message/MessageOptionsDialogFragment.kt
… track `VideoView`'s state since it's not exposed
… background color inside the main viewing area of the attachment gallery
…it was causing inconsistencies
…droid into feature/3369-video-thumbnails-ui-components-gallery � Conflicts: � CHANGELOG.md � stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/TransformStyle.kt
MarinTolic
changed the title
Feature/3369 video thumbnails UI components gallery
[3369] video thumbnails UI components gallery
Oct 18, 2022
…humbnails are disabled
MarinTolic
commented
Oct 18, 2022
...n/kotlin/io/getstream/chat/android/ui/gallery/internal/AttachmentGalleryVideoPageFragment.kt
Show resolved
Hide resolved
...chat-android-ui-components/src/main/res/layout/stream_ui_attachment_gallery_options_view.xml
Outdated
Show resolved
Hide resolved
...nts/src/main/kotlin/io/getstream/chat/android/ui/gallery/overview/MediaAttachmentGridView.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/io/getstream/chat/android/ui/gallery/internal/AttachmentGalleryVideoPageFragment.kt
Show resolved
Hide resolved
bychkovdmitry
suggested changes
Oct 19, 2022
...n/kotlin/io/getstream/chat/android/ui/gallery/internal/AttachmentGalleryVideoPageFragment.kt
Show resolved
Hide resolved
bychkovdmitry
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…droid into feature/3369-video-thumbnails-ui-components-gallery � Conflicts: � CHANGELOG.md
…re now incorrect.
MarinTolic
deleted the
feature/3369-video-thumbnails-ui-components-gallery
branch
October 20, 2022 16:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
closes #3369
🛠 Implementation details
Implemented the ability to display video items in the previously used image attachment gallery.
🎨 UI Changes
Gallery Offline
Gallery Online
Video Reproduction
🧪 Testing
Functionality Test
Customizability Test
Patch A:
Customizability Patch
Test B:
Patch that disables thumbnails
☑️Contributor Checklist
General
develop
branchCode & documentation
☑️Reviewer Checklist
🎉 GIF