Skip to content

Commit

Permalink
fix(trait):define the default trait name
Browse files Browse the repository at this point in the history
Make the default trait name not the same as the component name

Fixes crossplane#66

Signed-off-by: zhuhuijun <[email protected]>
  • Loading branch information
Ghostbaby committed Jul 9, 2020
1 parent 46dd69b commit 1f8d5d4
Showing 1 changed file with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -910,7 +910,6 @@ func TestGetComponent(t *testing.T) {
}, c)
}

<<<<<<< HEAD
var scheme = runtime.NewScheme()

func TestRenderTraitName(t *testing.T) {
Expand Down Expand Up @@ -1017,8 +1016,8 @@ func TestRenderTraitName(t *testing.T) {
traitName, err := r.getTraitName(context.Background(), namespace, componentName, &ac.Spec.Components[0].Traits[0], ref, &data)
assert.NoError(t, err)
assert.Equal(t, traitName, "component-trait-11111111")
}

=======
func TestPassThroughObjMeta(t *testing.T) {
c := components{}
ac := &v1alpha2.ApplicationConfiguration{}
Expand Down Expand Up @@ -1089,5 +1088,4 @@ func TestPassThroughObjMeta(t *testing.T) {
t.Errorf("labels got:%v,want:%v", gotLabels, wantLabels)
}
})
>>>>>>> upstream/master
}

0 comments on commit 1f8d5d4

Please sign in to comment.