Make the default trait name not the same as the component name #66

ryanzhang-oss · 2020-07-02T00:22:05Z

Currently, we use the component name as the trait name in the setTraitProperties function. It will be good for the name to indicate that it belongs to a trait

The text was updated successfully, but these errors were encountered:

Ghostbaby · 2020-07-05T04:14:08Z

@ryanzhang-oss Please assign to me.

name Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

…name Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

ryanzhang-oss · 2020-07-06T19:29:20Z

@ryanzhang-oss Please assign it to me.

Thank you very much for your help. Looks like you have successfully assigned it to yourself. Please create a pull request when you are ready

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]> Signed-off-by: erdun <[email protected]>

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]> Signed-off-by: erdun <[email protected]>

ryanzhang-oss added the good first issue Good for newcomers label Jul 2, 2020

wonderflow assigned Ghostbaby Jul 6, 2020

Ghostbaby mentioned this issue Jul 6, 2020

fix(trait):make the default trait name not the same as the component name #85

Merged

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 6, 2020

fix(trait):define the default trait name

3a68ed4

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 6, 2020

fix(trait):define the default trait name

272314e

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 7, 2020

fix(trait):define the default trait name

ccfde71

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 7, 2020

fix(trait):define the default trait name

c1d0efc

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 7, 2020

fix(trait):define the default trait name

805fdf8

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 7, 2020

fix(trait):define the default trait name

821b71d

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 7, 2020

fix(trait):define the default trait name

6ff2b63

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 8, 2020

fix(trait):define the default trait name

9cc1215

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 8, 2020

fix(trait):define the default trait name

95d6999

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 8, 2020

fix(trait):define the default trait name

d383e63

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 8, 2020

fix(trait):define the default trait name

aa560f7

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 8, 2020

fix(trait):define the default trait name

fa37078

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 8, 2020

fix(trait):define the default trait name

9b502b2

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 8, 2020

fix(trait):define the default trait name

ef692ea

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 8, 2020

fix(trait):define the default trait name

bace5d1

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 9, 2020

fix(trait):define the default trait name

5bbafee

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 9, 2020

fix(trait):define the default trait name

8bd01be

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 9, 2020

fix(trait):define the default trait name

1f8d5d4

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 9, 2020

fix(trait):define the default trait name

223bb2b

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 9, 2020

fix(trait):define the default trait name

87a319b

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 9, 2020

fix(trait):define the default trait name

dbd8e85

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 9, 2020

fix(trait):define the default trait name

59bc077

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 9, 2020

fix(trait):define the default trait name

be3d61b

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 9, 2020

fix(trait):define the default trait name

ecb243b

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 10, 2020

fix(trait):define the default trait name

1801ad8

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

zzxwill mentioned this issue Jul 11, 2020

support generate name auto oam-dev/spec#375

Open

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 14, 2020

fix(trait):define the default trait name

d31799e

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Ghostbaby added a commit to Ghostbaby/oam-kubernetes-runtime that referenced this issue Jul 14, 2020

fix(trait):define the default trait name

6461bfd

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

ryanzhang-oss closed this as completed in #85 Jul 15, 2020

erdun pushed a commit to erdun/oam-kubernetes-runtime that referenced this issue Jul 16, 2020

fix(trait):define the default trait name

d7df192

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

erdun pushed a commit to erdun/oam-kubernetes-runtime that referenced this issue Jul 16, 2020

fix(trait):define the default trait name

e7ed52f

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

erdun pushed a commit to erdun/oam-kubernetes-runtime that referenced this issue Jul 16, 2020

fix(trait):define the default trait name

11f6931

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

erdun pushed a commit to erdun/oam-kubernetes-runtime that referenced this issue Jul 16, 2020

fix(trait):define the default trait name

1f3cba1

Make the default trait name not the same as the component name Fixes crossplane#66 Signed-off-by: zhuhuijun <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make the default trait name not the same as the component name #66

Make the default trait name not the same as the component name #66

ryanzhang-oss commented Jul 2, 2020

Ghostbaby commented Jul 5, 2020

ryanzhang-oss commented Jul 6, 2020

Make the default trait name not the same as the component name #66

Make the default trait name not the same as the component name #66

Comments

ryanzhang-oss commented Jul 2, 2020

Ghostbaby commented Jul 5, 2020

ryanzhang-oss commented Jul 6, 2020