Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove service worker #936

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Remove service worker #936

merged 2 commits into from
Jul 29, 2020

Conversation

jrobbins
Copy link
Collaborator

@jrobbins jrobbins commented Jul 28, 2020

While service worker is awesome, it is not needed for this app. Removing it will simplify debugging of JS and CSS issues.

This will resolve issue #892.

@jrobbins jrobbins requested a review from aglaforge July 28, 2020 23:10
@jrobbins
Copy link
Collaborator Author

@lighthousebot
Copy link
Collaborator

Updated Lighthouse report for the changes in this PR:

Category New score Required threshold
Performance 76 -
Accessibility 46 -
Best Practices 71 -
SEO 90 -
Progressive Web App 73 -

Tested with Lighthouse version: 4.1.0

@jpmedley
Copy link
Contributor

What happens to all the people have installed this on desktops and home screens?

@lighthousebot
Copy link
Collaborator

Updated Lighthouse report for the changes in this PR:

Category New score Required threshold
Performance 75 -
Accessibility 46 -
Best Practices 71 -
SEO 90 -
Progressive Web App 73 -

Tested with Lighthouse version: 4.1.0

Copy link
Collaborator

@aglaforge aglaforge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. My operating assumption would be that the json fetch would end up in the user's local cache. Are we properly setting the Cache-Control value so that happens?

Copy link
Collaborator

@aglaforge aglaforge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed caching offline.

@jrobbins
Copy link
Collaborator Author

What happens to all the people have installed this on desktops and home screens?

I think that the icon disappears or it becomes a plain bookmark icon. The install button was only ever offered on mobile, so I don't think many users have it.

I added to my phone's home screen and then updated the staging server. The icon is still there, but it might disappear after 24 hours. I looked through various specs and docs and failed to find what the expected behavior is.

@jrobbins jrobbins merged commit 53a92ed into main Jul 29, 2020
@jrobbins jrobbins deleted the 20200728-remove-service-worker branch July 29, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants