Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: update chromestatus expecatations #11221

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Aug 4, 2020

Summary
Updates the chromestatus expectations to the new reality.

Alternatives Considered:

  • Remove chromestatus entirely
  • Replace chromestatus with another PWA
  • Host the old version of chromestatus somewhere else

None of those seem that much better to me, but if one of those does to you I'd be happy to debate them in a new PR once we can safely land our growing queue :)

Related Issues/PRs
GoogleChrome/chromium-dashboard#936

@patrickhulce patrickhulce requested a review from a team as a code owner August 4, 2020 22:10
@patrickhulce patrickhulce requested review from paulirish and removed request for a team August 4, 2020 22:10
Copy link
Collaborator

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 just to unblock CI.

Is airhorner enough for testing an actual pwa? if not, let's make an issue to really address this.

@patrickhulce
Copy link
Collaborator Author

@connorjclark we have 3 files dedicated to testing PWAs ;) pwa pwa2 pwa3 with airhorner, caltrain, svgomg, and your copy of pwa.rocks

@patrickhulce patrickhulce merged commit 434610e into master Aug 5, 2020
@patrickhulce patrickhulce deleted the update_expectations_chrome_status branch August 5, 2020 00:15
radum added a commit to radum/lighthouse that referenced this pull request Aug 13, 2020
* upstream/master: (42 commits)
  docs: add Code of Conduct to project (GoogleChrome#11212)
  docs(readme): add related project: lighthouse-viewer (GoogleChrome#11250)
  core(font-size): remove deprecated DOM.getFlattenedDocument (GoogleChrome#11248)
  misc: fix typo in method name (GoogleChrome#11239)
  i18n: make double dollar validation less strict (GoogleChrome#10299)
  misc: rephrase comments to be more inclusive (GoogleChrome#11228)
  misc: tweak gcp scripts to work in google corp (GoogleChrome#11233)
  v6.2.0 (GoogleChrome#11232)
  report: correctly display CLS in budget table (GoogleChrome#11209)
  report: vertically center thumbnails (GoogleChrome#11220)
  i18n: import (GoogleChrome#11225)
  tests: istanbul ignore inpage function (GoogleChrome#11229)
  deps(snyk): update script to prune <0.0.0 and update snapshot (GoogleChrome#11223)
  core(stacks): timeout stack detection (GoogleChrome#11172)
  core(config): unsized-images to default (GoogleChrome#11217)
  core(image-elements): collect CSS sizing, ShadowRoot, & position (GoogleChrome#11188)
  core: add FormElements gatherer (GoogleChrome#11062)
  new_audit: report animations not run on compositor (GoogleChrome#11105)
  tests: update chromestatus expecatations (GoogleChrome#11221)
  deps: update dot-prop secondary dependency (GoogleChrome#11198)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants