Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(smokehouse): do not assert on flaky node path #10827

Merged
merged 1 commit into from
May 28, 2020
Merged

tests(smokehouse): do not assert on flaky node path #10827

merged 1 commit into from
May 28, 2020

Conversation

connorjclark
Copy link
Collaborator

fixess #10734

I don't think these assertions are helping anything, so I removed all but one. I left reasoning in a comment.

For where the item became ambiguous w/o the node path, I added a content pattern check, which is much better.

@connorjclark connorjclark requested a review from a team as a code owner May 21, 2020 22:21
@connorjclark connorjclark requested review from paulirish and removed request for a team May 21, 2020 22:21
@connorjclark connorjclark changed the title test(smoke): do not assert on flaky devtoolsNodePath tests(smokehouse): do not assert on flaky devtoolsNodePath May 21, 2020
@connorjclark connorjclark changed the title tests(smokehouse): do not assert on flaky devtoolsNodePath tests(smokehouse): do not assert on flaky node path May 21, 2020
@paulirish paulirish merged commit f3d656a into master May 28, 2020
@paulirish paulirish deleted the byteflake branch May 28, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

Assignees

@paulirish paulirish

Labels
cla: yes waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connorjclark @paulirish @googlebot @devtools-bot