Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(smokehouse): do not assert on flaky node path #10827

Merged
merged 1 commit into from
May 28, 2020
Merged

tests(smokehouse): do not assert on flaky node path #10827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions lighthouse-cli/test/smokehouse/test-definitions/byte-efficiency/expectations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ const expectations = [
async: false,
defer: false,
source: 'head',
// Only do a single assertion for `devtoolsNodePath`: this can be flaky for elements
// deep in the DOM, and the sample LHR test has plenty of places that would catch
// a regression in `devtoolsNodePath` calculation. Keep just one for the benefit
// of other smoke test runners.
devtoolsNodePath: '2,HTML,0,HEAD,3,SCRIPT',
},
{
Expand All @@ -27,47 +31,43 @@ const expectations = [
async: false,
defer: false,
source: 'head',
devtoolsNodePath: '2,HTML,0,HEAD,5,SCRIPT',
},
{
type: null,
src: 'http://localhost:10200/byte-efficiency/bundle.js',
async: false,
defer: false,
source: 'head',
devtoolsNodePath: '2,HTML,0,HEAD,6,SCRIPT',
},
{
type: null,
src: null,
async: false,
defer: false,
source: 'body',
devtoolsNodePath: '2,HTML,1,BODY,0,DIV,3,SCRIPT',
content: /shadowRoot/,
},
{
type: null,
src: null,
async: false,
defer: false,
source: 'body',
devtoolsNodePath: '2,HTML,1,BODY,3,SCRIPT',
content: /generateInlineStyleWithSize/,
},
{
type: null,
src: 'http://localhost:10200/byte-efficiency/delay-complete.js?delay=8000',
async: true,
defer: false,
source: 'body',
devtoolsNodePath: '2,HTML,1,BODY,1438,SCRIPT',
},
{
type: null,
src: null,
async: false,
defer: false,
source: 'body',
devtoolsNodePath: '2,HTML,1,BODY,1439,SCRIPT',
content: /Used block #1/,
},
{
Expand All @@ -76,7 +76,6 @@ const expectations = [
async: false,
defer: false,
source: 'body',
devtoolsNodePath: '2,HTML,1,BODY,1440,SCRIPT',
content: /Unused block #1/,
},
],
Expand Down