Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(artifacts): encapsulate node details in an object (#11474) (reland) #11695

Merged
merged 9 commits into from
Dec 8, 2020
Merged

core(artifacts): encapsulate node details in an object (#11474) (reland) #11695

merged 9 commits into from
Dec 8, 2020

Commits on Dec 7, 2020

  1. Revert "Revert "core(artifacts): encapsulate node details in an object ( 

    #11474)""

This reverts commit 666057a.
    @paulirish
    paulirish committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    8e28eaf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into relandencap. still have 2 conflicts... 

    artifacts.json and sampl3v2json
    @paulirish
    paulirish committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    4094002 View commit details
    Browse the repository at this point in the history

  3. ran this and it probaly changed too much: 'yarn update:sample-artifac… 

    …ts ScriptElements LinkElements ImageElements AnchorElements TapTargets TraceElements'
    @paulirish
    paulirish committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    d4422aa View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. set artifacts.json back to original nodedetails-object state

    @paulirish
    paulirish committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    7c6bb7b View commit details
    Browse the repository at this point in the history

  2. manually drop resourceSize from ImageElements

    @paulirish
    paulirish committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    2ac625e View commit details
    Browse the repository at this point in the history

  3. just 'yarn update:sample-artifacts ImageElements'

    @paulirish
    paulirish committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    f1ca2a1 View commit details
    Browse the repository at this point in the history

  4. update samplejson

    @paulirish
    paulirish committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    f1ec79e View commit details
    Browse the repository at this point in the history

  5. restore some artifacts.json data that was lost earlier

    @paulirish
    paulirish committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    28cdb0c View commit details
    Browse the repository at this point in the history

  6. add back mimeType to ImageElements type

    @paulirish
    paulirish committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    b9658ec View commit details
    Browse the repository at this point in the history