Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(artifacts): encapsulate node details in an object (#11474) (reland) #11695

Merged
merged 9 commits into from
Dec 8, 2020
Merged

core(artifacts): encapsulate node details in an object (#11474) (reland) #11695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8e28eaf
Revert "Revert "core(artifacts): encapsulate node details in an objec…
paulirish Nov 20, 2020
4094002
Merge branch 'master' into relandencap. still have 2 conflicts...
paulirish Dec 7, 2020
d4422aa
ran this and it probaly changed too much: 'yarn update:sample-artifac…
paulirish Dec 7, 2020
7c6bb7b
set artifacts.json back to original nodedetails-object state
paulirish Dec 8, 2020
2ac625e
manually drop resourceSize from ImageElements
paulirish Dec 8, 2020
f1ca2a1
just 'yarn update:sample-artifacts ImageElements'
paulirish Dec 8, 2020
f1ec79e
update samplejson
paulirish Dec 8, 2020
28cdb0c
restore some artifacts.json data that was lost earlier
paulirish Dec 8, 2020
b9658ec
add back mimeType to ImageElements type
paulirish Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lighthouse-cli/test/smokehouse/test-definitions/byte-efficiency/expectations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ const expectations = [
// deep in the DOM, and the sample LHR test has plenty of places that would catch
// a regression in `devtoolsNodePath` calculation. Keep just one for the benefit
// of other smoke test runners.
devtoolsNodePath: '2,HTML,0,HEAD,3,SCRIPT',
node: {
devtoolsNodePath: '2,HTML,0,HEAD,3,SCRIPT',
},
},
{
type: 'application/javascript',
Expand Down
Loading