deps: update jsonld to latest #12257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Mar 18, 2021
| @@ -98,7 +98,7 @@ describe('JSON-LD validation', () => { | |||
| const errors = await validateJSONLD(`{ | |||
| "@context": { | |||
| "image": { | |||
| "@id": "@error" | |||
| "@id": "/error/" | |||
There was a problem hiding this comment.
'@error' here became a warning, so this uses a different invalid value
| "jsonld": "^1.5.0", | ||
| "jsonlint-mod": "^1.7.5", | ||
| "jsonld": "^4.0.1", | ||
| "jsonlint-mod": "^1.7.6", |
| } | ||
|
|
||
| export function expand(object: any, options: JsonldOptions): Promise<any>; | ||
| export function expand(object: unknown, options: JsonldOptions): Promise<any>; |
There was a problem hiding this comment.
there are definitelytyped types for jsonld now, but expand() still has the old callback-based documentLoader, so easier to still just maintain types for our own tiny corner of the library. It would be nice to eventually switch and not rely on LH.StructuredData.ExpandedSchemaRepresentation being the source of truth, though.
paulirish
approved these changes
Mar 18, 2021
brendankenny
force-pushed
the
bumpjsonld
branch
from
4252045
to
dbbb499
Compare
adamraine
approved these changes
Mar 18, 2021
paulirish
pushed a commit
that referenced
this pull request
Mar 23, 2021
This was referenced Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12244
We only use
require('jsonld').expand(), so it was a pretty easy update :)