-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update jsonld to latest #12257
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -171,8 +171,8 @@ | |
"intl-pluralrules": "^1.0.3", | ||
"jpeg-js": "^0.4.1", | ||
"js-library-detector": "^6.4.0", | ||
"jsonld": "^1.5.0", | ||
"jsonlint-mod": "^1.7.5", | ||
"jsonld": "^4.0.1", | ||
"jsonlint-mod": "^1.7.6", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why not |
||
"lighthouse-logger": "^1.2.0", | ||
"lighthouse-stack-packs": "^1.4.0", | ||
"lodash.get": "^4.4.2", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,11 +5,15 @@ | |
*/ | ||
|
||
declare module 'jsonld' { | ||
type CallbackFn = (err: null|Error, result?: any) => void | ||
interface RemoteDocument { | ||
contextUrl?: string; | ||
documentUrl?: string; | ||
document: unknown; | ||
} | ||
|
||
interface JsonldOptions { | ||
documentLoader: (url: string, callback: CallbackFn) => void | ||
documentLoader: (url: string) => Promise<RemoteDocument>; | ||
} | ||
|
||
export function expand(object: any, options: JsonldOptions): Promise<any>; | ||
export function expand(object: unknown, options: JsonldOptions): Promise<any>; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there are definitelytyped types for |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'@error'
here became a warning, so this uses a different invalid value