Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: accessible n/a icon #12984

Merged
merged 1 commit into from
Aug 27, 2021
Merged

report: accessible n/a icon #12984

merged 1 commit into from
Aug 27, 2021

Conversation

adamraine
Copy link
Member

Redesign proposal for gray passing icon.

Stole this from our mocks for #12973

Fixes #12231

@adamraine adamraine requested a review from a team as a code owner August 25, 2021 19:14
@adamraine adamraine requested review from connorjclark and removed request for a team August 25, 2021 19:14
@google-cla google-cla bot added the cla: yes label Aug 25, 2021
@connorjclark
Copy link
Collaborator

connorjclark commented Aug 25, 2021

pics or didn't happen :)

maybe add a new report to sample-reports?

@adamraine
Copy link
Member Author

maybe add a new report to sample-reports?

I kinda assumed this would already be in one of the sample reports, either way here is a pic

Screen Shot 2021-08-25 at 4 04 08 PM

@patrickhulce
Copy link
Collaborator

I kinda assumed this would already be in one of the sample reports

It is, but it wasn't super obvious what the before/after was :)

Before After
image image

@adamraine adamraine merged commit 244364c into master Aug 27, 2021
@adamraine adamraine deleted the report-na-icon branch August 27, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign green passing circle / grey passing circle
4 participants