report: group perf audits by details type #13241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| !Util.showAsPassed(audit.result)); | ||
| const oppAudits = category.auditRefs.filter(audit => | ||
| audit.result.details && | ||
| audit.result.details.type === 'opportunity' && |
There was a problem hiding this comment.
if the logic for determining opportunity is used in many different files (I've only counted two so far in my review tho) would be worth moving to renderer util.
There was a problem hiding this comment.
looks great! not sure the best place for it, but it would be good to document somewhere the special perf category handling, either in render or maybe on @connorjclark's suggested classifyPerformanceAudit function
connorjclark
approved these changes
Oct 29, 2021
…thouse into report-perf-auto-group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12828, allowing h2 audit in timespan mode.
No audits in the default config have group
load-opportunitiesordiagnosticsanymore. Havinggroupunset now means the renderer will automatically choose the group based on the audit details type.Couple more ideas:
load-opportunitiesordiagnostics, put in specified group without looking at result details. This means the renderer could still support legacy LHRs.hiddengroup, have anautogroup and revert to hiding audits with no group in perf.Ref #11313