Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: group perf audits by details type #13241

Merged
merged 16 commits into from
Nov 1, 2021
Merged

report: group perf audits by details type #13241

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
9fd3042
report: group perf audits by details type
adamraine Oct 21, 2021
a7f6c42
comments
adamraine Oct 21, 2021
e323ff1
budgets
adamraine Oct 21, 2021
8e8e948
classify
adamraine Oct 21, 2021
af4dc27
hidden test
adamraine Oct 21, 2021
17687c6
update sample
adamraine Oct 21, 2021
1cec774
viewer test
adamraine Oct 21, 2021
08a3a59
test
adamraine Oct 21, 2021
e70a9f9
Merge branch 'master' into report-perf-auto-group
adamraine Oct 28, 2021
b83f75a
Merge branch 'master' into report-perf-auto-group
adamraine Nov 1, 2021
57f4487
hidden
adamraine Nov 1, 2021
42e3881
Merge branch 'master' into report-perf-auto-group
adamraine Nov 1, 2021
b219bcb
comment
adamraine Nov 1, 2021
54c0502
Merge branch 'report-perf-auto-group' of github.com:GoogleChrome/ligh…
adamraine Nov 1, 2021
e0be101
Merge branch 'master' into report-perf-auto-group
adamraine Nov 1, 2021
329b261
Merge branch 'master' into report-perf-auto-group
adamraine Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions flow-report/test/summary/category-test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ describe('SummaryTooltip', () => {
id: 'performance',
score: 1,
auditRefs: [
{result: {score: 1, scoreDisplayMode: 'binary'}, weight: 1, group: 'diagnostics'},
{result: {score: 1, scoreDisplayMode: 'binary'}, weight: 1, group: 'diagnostics'},
{result: {score: 0, scoreDisplayMode: 'binary'}, weight: 1, group: 'diagnostics'},
{result: {score: 1, scoreDisplayMode: 'binary'}, weight: 1, group: 'metrics'},
{result: {score: 1, scoreDisplayMode: 'binary'}, weight: 1, group: 'metrics'},
{result: {score: 0, scoreDisplayMode: 'binary'}, weight: 1, group: 'metrics'},
],
};

Expand All @@ -53,9 +53,9 @@ describe('SummaryTooltip', () => {
id: 'performance',
score: 1,
auditRefs: [
{result: {score: 1, scoreDisplayMode: 'binary'}, weight: 0, group: 'diagnostics'},
{result: {score: 1, scoreDisplayMode: 'binary'}, weight: 0, group: 'diagnostics'},
{result: {score: 0, scoreDisplayMode: 'binary'}, weight: 0, group: 'diagnostics'},
{result: {score: 1, scoreDisplayMode: 'binary'}, weight: 0, group: 'metrics'},
{result: {score: 1, scoreDisplayMode: 'binary'}, weight: 0, group: 'metrics'},
{result: {score: 0, scoreDisplayMode: 'binary'}, weight: 0, group: 'metrics'},
],
};

Expand All @@ -75,9 +75,9 @@ describe('SummaryTooltip', () => {
id: 'performance',
score: 1,
auditRefs: [
{result: {score: 1, scoreDisplayMode: 'binary'}, weight: 1, group: 'diagnostics'},
{result: {score: 1, scoreDisplayMode: 'binary'}, weight: 1, group: 'diagnostics'},
{result: {score: 0, scoreDisplayMode: 'binary'}, weight: 1, group: 'diagnostics'},
{result: {score: 1, scoreDisplayMode: 'binary'}, weight: 1, group: 'metrics'},
{result: {score: 1, scoreDisplayMode: 'binary'}, weight: 1, group: 'metrics'},
{result: {score: 0, scoreDisplayMode: 'binary'}, weight: 1, group: 'metrics'},
],
};

Expand All @@ -97,9 +97,9 @@ describe('SummaryTooltip', () => {
id: 'performance',
score: 1,
auditRefs: [
{result: {score: 1, scoreDisplayMode: 'binary'}, weight: 1, group: 'diagnostics'},
{result: {score: 1, scoreDisplayMode: 'binary'}, weight: 1, group: 'diagnostics'},
{result: {score: 0, scoreDisplayMode: 'informative'}, weight: 1, group: 'diagnostics'},
{result: {score: 1, scoreDisplayMode: 'binary'}, weight: 1, group: 'metrics'},
{result: {score: 1, scoreDisplayMode: 'binary'}, weight: 1, group: 'metrics'},
{result: {score: 0, scoreDisplayMode: 'informative'}, weight: 1, group: 'metrics'},
],
};

Expand Down
59 changes: 18 additions & 41 deletions lighthouse-cli/test/cli/__snapshots__/index-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,252 +929,222 @@ Object {
"weight": 15,
},
Object {
"group": "hidden",
"id": "max-potential-fid",
"weight": 0,
},
Object {
"acronym": "FMP",
"group": "hidden",
"id": "first-meaningful-paint",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "render-blocking-resources",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "uses-responsive-images",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "offscreen-images",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "unminified-css",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "unminified-javascript",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "unused-css-rules",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "unused-javascript",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "uses-optimized-images",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "modern-image-formats",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "uses-text-compression",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "uses-rel-preconnect",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "server-response-time",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "redirects",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "uses-rel-preload",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "uses-http2",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "efficient-animated-content",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "duplicated-javascript",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "legacy-javascript",
"weight": 0,
},
Object {
"group": "load-opportunities",
"id": "preload-lcp-image",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "total-byte-weight",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "uses-long-cache-ttl",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "dom-size",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "critical-request-chains",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "user-timings",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "bootup-time",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "mainthread-work-breakdown",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "font-display",
"weight": 0,
},
Object {
"group": "budgets",
"id": "performance-budget",
"weight": 0,
},
Object {
"group": "budgets",
"id": "timing-budget",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "resource-summary",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "third-party-summary",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "third-party-facades",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "largest-contentful-paint-element",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "lcp-lazy-loaded",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "layout-shift-elements",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "uses-passive-event-listeners",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "no-document-write",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "long-tasks",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "non-composited-animations",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "unsized-images",
"weight": 0,
},
Object {
"group": "diagnostics",
"id": "viewport",
"weight": 0,
},
Object {
"group": "hidden",
"id": "network-requests",
"weight": 0,
},
Object {
"group": "hidden",
"id": "network-rtt",
"weight": 0,
},
Object {
"group": "hidden",
"id": "network-server-latency",
"weight": 0,
},
Object {
"group": "hidden",
"id": "main-thread-tasks",
"weight": 0,
},
Object {
"group": "hidden",
"id": "diagnostics",
"weight": 0,
},
Object {
"group": "hidden",
"id": "metrics",
"weight": 0,
},
Object {
"group": "hidden",
"id": "screenshot-thumbnails",
"weight": 0,
},
Object {
"group": "hidden",
"id": "final-screenshot",
"weight": 0,
},
Object {
"group": "hidden",
"id": "script-treemap-data",
"weight": 0,
},
Expand Down Expand Up @@ -1387,6 +1357,9 @@ Object {
"description": "More information about the performance of your application. These numbers don't [directly affect](https://web.dev/performance-scoring/) the Performance score.",
"title": "Diagnostics",
},
"hidden": Object {
"title": "",
},
"load-opportunities": Object {
"description": "These suggestions can help your page load faster. They don't [directly affect](https://web.dev/performance-scoring/) the Performance score.",
"title": "Opportunities",
Expand Down Expand Up @@ -1586,6 +1559,7 @@ Object {
"performance": Object {
"auditRefs": Array [
Object {
"group": "hidden",
"id": "metrics",
"weight": 0,
},
Expand Down Expand Up @@ -1651,6 +1625,9 @@ Object {
"description": "More information about the performance of your application. These numbers don't [directly affect](https://web.dev/performance-scoring/) the Performance score.",
"title": "Diagnostics",
},
"hidden": Object {
"title": "",
},
"load-opportunities": Object {
"description": "These suggestions can help your page load faster. They don't [directly affect](https://web.dev/performance-scoring/) the Performance score.",
"title": "Opportunities",
Expand Down
Loading