-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: remove service-worker
audit
#15257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Jul 12, 2023
requestedUrl: 'http://localhost:10503/offline-ready.html?slow', | ||
finalDisplayedUrl: 'http://localhost:10503/offline-ready.html?slow', | ||
audits: { | ||
'service-worker': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only audit we check in this smoke test, so it doesn't seem useful anymore.
connorjclark
approved these changes
Jul 17, 2023
@adamraine how to re-enable this audit manually? |
It's not possible ATM, but you could create a custom audit with the same implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification from internal email discussion:
Edit: I may have jumped the gun on removing this audit. We should land #15253 first.DoneKeeping the
ServiceWorker
gatherer around like we do withIFrameElements
. I'm open to removing completely though.Some SW related drive by updates in
core/audits/installable-manifest.js
#14909