Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove service-worker audit #15257

Merged
merged 9 commits into from
Jul 17, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions cli/test/smokehouse/test-definitions/offline-online-only.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ const config = {
],
onlyAudits: [
'is-on-https',
'service-worker',
'viewport',
'user-timings',
'critical-request-chains',
Expand Down Expand Up @@ -53,9 +52,6 @@ const expectations = {
'paste-preventing-inputs': {
score: 1,
},
'service-worker': {
score: 0,
},
'viewport': {
score: 1,
},
Expand Down
8 changes: 0 additions & 8 deletions cli/test/smokehouse/test-definitions/offline-ready.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ const config = {
],
onlyAudits: [
'is-on-https',
'service-worker',
'viewport',
'user-timings',
'critical-request-chains',
Expand Down Expand Up @@ -70,13 +69,6 @@ const expectations = {
'is-on-https': {
score: 1,
},
'service-worker': {
score: 1,
details: {
scriptUrl: 'http://localhost:10503/offline-ready-sw.js',
scopeUrl: 'http://localhost:10503/',
},
},
'viewport': {
score: 1,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ const config = {
],
onlyAudits: [
'is-on-https',
'service-worker',
'viewport',
'user-timings',
'critical-request-chains',
Expand Down
60 changes: 0 additions & 60 deletions cli/test/smokehouse/test-definitions/offline-sw-slow.js

This file was deleted.

3 changes: 0 additions & 3 deletions cli/test/smokehouse/test-definitions/pwa-airhorner.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ const expectations = {
requestedUrl: 'https://airhorner.com',
finalDisplayedUrl: 'https://airhorner.com/',
audits: {
'service-worker': {
score: 1,
},
'viewport': {
score: 1,
},
Expand Down
3 changes: 0 additions & 3 deletions cli/test/smokehouse/test-definitions/pwa-caltrain.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ const expectations = {
requestedUrl: 'https://caltrainschedule.io/',
finalDisplayedUrl: 'https://caltrainschedule.io/',
audits: {
'service-worker': {
score: 1,
},
'viewport': {
score: 1,
},
Expand Down
3 changes: 0 additions & 3 deletions cli/test/smokehouse/test-definitions/pwa-chromestatus.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ const expectations = {
requestedUrl: 'https://chromestatus.com/features',
finalDisplayedUrl: 'https://chromestatus.com/features',
audits: {
'service-worker': {
score: 0,
},
'viewport': {
score: 1,
},
Expand Down
3 changes: 0 additions & 3 deletions cli/test/smokehouse/test-definitions/pwa-rocks.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ const expectations = {
requestedUrl: 'https://connorjclark.github.io/pwa.rocks/',
finalDisplayedUrl: 'https://connorjclark.github.io/pwa.rocks/',
audits: {
'service-worker': {
score: 1,
},
'viewport': {
score: 1,
},
Expand Down
3 changes: 0 additions & 3 deletions cli/test/smokehouse/test-definitions/pwa-svgomg.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ const expectations = {
requestedUrl: 'https://jakearchibald.github.io/svgomg/',
finalDisplayedUrl: 'https://jakearchibald.github.io/svgomg/',
audits: {
'service-worker': {
score: 1,
},
'viewport': {
score: 1,
},
Expand Down
9 changes: 2 additions & 7 deletions core/audits/installable-manifest.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,6 @@ const UIStrings = {
'manifest-display-not-supported': `Manifest 'display' property must be one of 'standalone', 'fullscreen', or 'minimal-ui'`,
/** Error message explaining that the manifest could not be fetched, might be empty, or could not be parsed. */
'manifest-empty': `Manifest could not be fetched, is empty, or could not be parsed`,
// TODO: This error was removed in M114, we can remove this message when it hits stable.
/** Error message explaining that no matching service worker was detected,
* and provides a suggestion to reload the page or check whether the scope of the service worker
* for the current page encloses the scope and start URL from the manifest. */
'no-matching-service-worker': `No matching service worker detected. You may need to reload the page, or check that the scope of the service worker for the current page encloses the scope and start URL from the manifest.`,
/**
* @description Error message explaining that the manifest does not contain a suitable icon.
* @example {192} value0
Expand Down Expand Up @@ -93,8 +88,8 @@ const UIStrings = {
'manifest-location-changed': `Manifest URL changed while the manifest was being fetched.`,
/** Warning message explaining that the page does not work offline. */
'warn-not-offline-capable': `Page does not work offline. The page will not be regarded as installable after Chrome 93, stable release August 2021.`,
/** Error message explaining that Lighthouse failed while detecting a service worker, and directing the user to try again in a new Chrome. */
'protocol-timeout': `Lighthouse could not determine if there was a service worker. Please try with a newer version of Chrome.`,
/** Error message explaining that Lighthouse failed while checking if the page is installable, and directing the user to try again in a new Chrome. */
'protocol-timeout': `Lighthouse could not determine if the page is installable. Please try with a newer version of Chrome.`,
/** Message logged when the web app has been uninstalled o desktop, signalling that the install banner state is being reset. */
'pipeline-restarted': 'PWA has been uninstalled and installability checks resetting.',
/**
Expand Down
182 changes: 0 additions & 182 deletions core/audits/service-worker.js

This file was deleted.

2 changes: 0 additions & 2 deletions core/config/default-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ const defaultConfig = {
],
audits: [
'is-on-https',
'service-worker',
'viewport',
'metrics/first-contentful-paint',
'metrics/largest-contentful-paint',
Expand Down Expand Up @@ -638,7 +637,6 @@ const defaultConfig = {
// Installable
{id: 'installable-manifest', weight: 2, group: 'pwa-installable'},
// PWA Optimized
{id: 'service-worker', weight: 1, group: 'pwa-optimized'},
{id: 'splash-screen', weight: 1, group: 'pwa-optimized'},
{id: 'themed-omnibox', weight: 1, group: 'pwa-optimized'},
{id: 'content-width', weight: 1, group: 'pwa-optimized'},
Expand Down
Loading