fix: remove requests after they have been completed (#2302)

Refs #2301
GoogleChromeLabs · Jun 10, 2024 · e4b4139 · e4b4139
1 parent ce7a305
commit e4b4139
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 4 deletions.
diff --git a/src/bidiMapper/modules/network/NetworkRequest.ts b/src/bidiMapper/modules/network/NetworkRequest.ts
@@ -274,6 +274,7 @@ export class NetworkRequest {
       responseInterceptionCompleted
     ) {
       this.#emitEvent(this.#getResponseReceivedEvent.bind(this));
+      this.#networkStorage.deleteRequest(this.id);
     }
   }
 

diff --git a/tests/network/test_continue_request.py b/tests/network/test_continue_request.py
@@ -308,7 +308,7 @@ async def test_continue_request_twice(websocket, context_id, example_url):
             Exception,
             match=str({
                 "error": "no such request",
-                "message": f"No blocked request found for network id '{network_id}'"
+                "message": f"Network request with ID '{network_id}' doesn't exist"
             })):
         await execute_command(
             websocket, {

diff --git a/tests/network/test_continue_response.py b/tests/network/test_continue_response.py
@@ -425,7 +425,7 @@ async def test_continue_response_twice(websocket, context_id, example_url):
             Exception,
             match=str({
                 "error": "no such request",
-                "message": f"No blocked request found for network id '{network_id}'"
+                "message": f"Network request with ID '{network_id}' doesn't exist"
             })):
         await execute_command(
             websocket, {

diff --git a/tests/network/test_continue_with_auth.py b/tests/network/test_continue_with_auth.py
@@ -297,7 +297,7 @@ async def test_continue_with_auth_twice(websocket, context_id,
             Exception,
             match=str({
                 "error": "no such request",
-                "message": f"No blocked request found for network id '{network_id}'"
+                "message": f"Network request with ID '{network_id}' doesn't exist"
             })):
         await execute_command(
             websocket, {

diff --git a/tests/network/test_provide_response.py b/tests/network/test_provide_response.py
@@ -378,7 +378,7 @@ async def test_provide_response_twice(websocket, context_id, example_url):
             Exception,
             match=str({
                 "error": "no such request",
-                "message": f"No blocked request found for network id '{network_id}'"
+                "message": f"Network request with ID '{network_id}' doesn't exist"
             })):
         await execute_command(
             websocket, {