Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove requests after they have been completed #2302

Merged
merged 2 commits into from
Jun 10, 2024
Merged

fix: remove requests after they have been completed #2302

merged 2 commits into from
Jun 10, 2024

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Jun 10, 2024 •
edited
Loading

Refs #2301

@OrKoN OrKoN marked this pull request as ready for review June 10, 2024 15:24
@OrKoN
Copy link
Collaborator Author

OrKoN commented Jun 10, 2024

@Lightning00Blade wdyt? it looks like some e2e tests expect requests to linger in storage forever. What is the best way to fix this?

@OrKoN
Copy link
Collaborator Author

OrKoN commented Jun 10, 2024

I think we can update expected error messages.

@OrKoN OrKoN added the puppeteer Run Puppeteer test when added to PR label Jun 10, 2024
@OrKoN OrKoN closed this Jun 10, 2024
@OrKoN OrKoN reopened this Jun 10, 2024
Lightning00Blade
Lightning00Blade approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@Lightning00Blade Lightning00Blade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
should be OK to update the error message, though from an user perspective it may be less clear.

@OrKoN OrKoN merged commit e4b4139 into main Jun 10, 2024
68 of 94 checks passed
@OrKoN OrKoN deleted the orkon/fix-network-leak branch June 10, 2024 16:19
@release-please release-please bot mentioned this pull request Jun 10, 2024
Merged
OrKoN pushed a commit that referenced this pull request Jun 11, 2024
@release-please
chore(main): release chromium-bidi 0.5.23 (#2303)
1e52719 
🤖 I have created a release *beep* *boop*
---


##
[0.5.23](chromium-bidi-v0.5.22...chromium-bidi-v0.5.23)
(2024-06-11)


### Bug Fixes

* remove requests after they have been completed
([#2302](#2302))
([e4b4139](e4b4139)),
closes
[#2301](#2301)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lightning00Blade Lightning00Blade Lightning00Blade approved these changes

Assignees
No one assigned
Labels
puppeteer Run Puppeteer test when added to PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrKoN @Lightning00Blade