Network and Fetch domain activation #1080
Assignees
Labels
enhancement
New feature or request
Comments
thiagowfx
pushed a commit
that referenced
this issue
Jul 24, 2023
thiagowfx
pushed a commit
that referenced
this issue
Jul 24, 2023
thiagowfx
pushed a commit
that referenced
this issue
Jul 24, 2023
thiagowfx
pushed a commit
that referenced
this issue
Jul 24, 2023
thiagowfx
pushed a commit
that referenced
this issue
Jul 24, 2023
thiagowfx
pushed a commit
that referenced
this issue
Jul 24, 2023
thiagowfx
changed the title
2 tasks
|
cc @sadym-chromium FYI as this slightly relates to supporting multiple BiDi/CDP sessions. |
ack |
thiagowfx
pushed a commit
that referenced
this issue
Oct 10, 2023
Furthermore, update some E2E tests so that they do not rely on CDP events. Bug #644, #1080 Co-authored-by: Maksim Sadym <[email protected]> Re-created from #1400.
|
|
|
This should be resolved and we should be enabling both |
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the network domain is incorrectly enabled.
The network domain should be enabled via the CDP client/target, only when the browsing context has...
network.events, and/orIt's important to not do
Network.enableglobally, otherwise we'd emit too many unnecessary CDP events, when the client may not be interested in them.Edit(2023-09-11): @Lightning00Blade: It seems that if we never enable interception we always call
Fetch.disableon target create, I think it would be good it we omit that that way its a little bit faster for WPT and other test.(Update by @Lightning00Blade) Investigated the performance cost related to always enabling the
Fetchdomain can be found at go/webdriver-bidi:network-interception-performance-delta.The biggest delta that we observed is around 8-9%, when navigating to a page and continuing the request as normal.
The text was updated successfully, but these errors were encountered: