feat: unblock event queue when network events are blocked #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagowfx
force-pushed
the
thiagowfx/network-events
branch
2 times, most recently
from
601591e
to
8faae96
Compare
thiagowfx
force-pushed
the
thiagowfx/network-events
branch
from
8faae96
to
1f47acb
Compare
thiagowfx
force-pushed
the
thiagowfx/network-events
branch
7 times, most recently
from
bd95212
to
9aa5b47
Compare
|
It's just missing "continue request", but sending out for review already. |
thiagowfx
commented
Oct 10, 2023
| @@ -143,7 +130,7 @@ export class CdpTarget { | |||
| // XXX: #1080: Do not always enable the network domain globally. | |||
| // TODO: enable Network domain for OOPiF targets. | |||
| this.#cdpClient.sendCommand('Network.enable'), | |||
| this.fetchApply(), | |||
| this.fetchEnable(), | |||
There was a problem hiding this comment.
Could you elaborate? This change is a no-op.
The more general issue you're referring to is: #1080
| [ | ||
| { | ||
| "type": "string", | ||
| "pattern": "https://www.example.com/", |
There was a problem hiding this comment.
Can you use a fixture example_url instead of const example.com?
There was a problem hiding this comment.
It's not possible to use fixtures in parameters: pytest-dev/pytest#349
There was a problem hiding this comment.
We could expose a global string instead of a fixture. Or we could break the test down into multiple functions so that it is not parameterized anymore. Otherwise it's not really possible at the moment.
There was a problem hiding this comment.
Actually, I forgot to mention a third possibility: We could use a pytest plug-in that allows so. Do you have a preference? See the upstream issue above.
sadym-chromium
approved these changes
Oct 10, 2023
thiagowfx
force-pushed
the
thiagowfx/network-events
branch
from
a51b46b
to
af34d34
Compare
thiagowfx
force-pushed
the
thiagowfx/network-events
branch
from
af34d34
to
c0635c0
Compare
added 7 commits
October 10, 2023 17:45
Furthermore, update some E2E tests so that they do not rely on CDP events. Bug #644 Co-authored-by: Maksim Sadym <[email protected]>
added 11 commits
October 10, 2023 17:45
…blocked requests Issue #1080
thiagowfx
force-pushed
the
thiagowfx/network-events
branch
from
090d324
to
4ac2b4e
Compare
jrandolf-2
pushed a commit
that referenced
this pull request
Oct 16, 2023
🤖 I have created a release *beep* *boop* --- ## [0.4.32](chromium-bidi-v0.4.31...chromium-bidi-v0.4.32) (2023-10-16) ### Features * add quality for `webp` ([#1426](#1426)) ([d514bf9](d514bf9)) * implement device pixel ratio changes ([#1422](#1422)) ([49f6dee](49f6dee)) * implement document origin screenshots ([#1427](#1427)) ([b952297](b952297)) * **network interception:** implement continue request ([#1331](#1331)) ([8a935b9](8a935b9)), closes [#644](#644) * session handling refactoring. Step 1 ([#1385](#1385)) ([8fe37b9](8fe37b9)) * unblock event queue when network events are blocked ([#1409](#1409)) ([e94f79d](e94f79d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Furthermore, update some E2E tests so that they do not rely on CDP events.
Bug #644, #1080
Co-authored-by: Maksim Sadym [email protected]
Re-created from #1400.