Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(chrome): update the pinned browser version #885

Merged
merged 2 commits into from
Jul 4, 2023
Merged

build(chrome): update the pinned browser version #885

merged 2 commits into from
Jul 4, 2023

Conversation

browser-automation-bot
Copy link
Contributor

@browser-automation-bot browser-automation-bot commented Jun 26, 2023 •
edited
Loading

@browser-automation-bot browser-automation-bot added the dependencies Pull requests that update a dependency file label Jun 26, 2023
@OrKoN OrKoN force-pushed the browser-automation-bot/update-browser-version branch from 5ab5ba6 to 200f5c0 Compare June 26, 2023 11:27
@thiagowfx
Copy link
Contributor

With this PR, many print tests are timing out. This is not great.

@jrandolf-2 jrandolf-2 force-pushed the browser-automation-bot/update-browser-version branch from 1060798 to 34794f2 Compare June 28, 2023 09:28
@jrandolf-2 jrandolf-2 force-pushed the browser-automation-bot/update-browser-version branch from 34794f2 to a0e61b7 Compare June 28, 2023 11:10
@jrandolf-2 jrandolf-2 disabled auto-merge June 28, 2023 11:10
@browser-automation-bot browser-automation-bot force-pushed the browser-automation-bot/update-browser-version branch 3 times, most recently from 56dedc2 to eaa1438 Compare June 29, 2023 09:05
@thiagowfx thiagowfx enabled auto-merge (squash) June 29, 2023 09:09
@thiagowfx
Copy link
Contributor

Sadly, still timing out

@browser-automation-bot browser-automation-bot force-pushed the browser-automation-bot/update-browser-version branch from eaa1438 to 3ffa28d Compare June 29, 2023 22:14
@thiagowfx thiagowfx force-pushed the browser-automation-bot/update-browser-version branch from 0091a98 to d1574b3 Compare June 29, 2023 23:42
@thiagowfx thiagowfx disabled auto-merge June 29, 2023 23:45
@OrKoN
Copy link
Collaborator

OrKoN commented Jun 30, 2023

@thiagowfx could you reproduce locally? I think it is important to unblock the roller

@browser-automation-bot browser-automation-bot force-pushed the browser-automation-bot/update-browser-version branch from dcf6b63 to 896800b Compare June 30, 2023 09:35
@thiagowfx
Copy link
Contributor

Yes it also times out locally. For example, with print to pdf tests.

@OrKoN
Copy link
Collaborator

OrKoN commented Jun 30, 2023

@thiagowfx python3 -m pytest tests/test_print.py? or some other test?

@OrKoN
Copy link
Collaborator

OrKoN commented Jun 30, 2023

it looks like print fails because of #914

@OrKoN
Copy link
Collaborator

OrKoN commented Jun 30, 2023

I don't see timeouts locally

@OrKoN
Copy link
Collaborator

OrKoN commented Jun 30, 2023

I think one of the hanging ones is test_preloadScript_channel_navigate

@OrKoN
Copy link
Collaborator

OrKoN commented Jun 30, 2023

looks like a bug in serialization

@browser-automation-bot browser-automation-bot force-pushed the browser-automation-bot/update-browser-version branch from d32b601 to b1a6790 Compare July 3, 2023 00:27
This was referenced Jul 3, 2023
Closed
Merged
@browser-automation-bot browser-automation-bot force-pushed the browser-automation-bot/update-browser-version branch from b1a6790 to bcd6895 Compare July 3, 2023 11:34
@thiagowfx
Copy link
Contributor

Bug: #940

@thiagowfx thiagowfx force-pushed the browser-automation-bot/update-browser-version branch from bcd6895 to ababf22 Compare July 3, 2023 12:37
@thiagowfx
Copy link
Contributor

today: [email protected]

@browser-automation-bot browser-automation-bot force-pushed the browser-automation-bot/update-browser-version branch 2 times, most recently from 5373449 to 654dc3a Compare July 3, 2023 22:37
@thiagowfx
Copy link
Contributor

thiagowfx commented Jul 4, 2023 •
edited
Loading

5869 still fails. Probably need to wait until tomorrow.

@browser-automation-bot browser-automation-bot force-pushed the browser-automation-bot/update-browser-version branch from 654dc3a to 3b78d43 Compare July 4, 2023 13:37
@thiagowfx thiagowfx mentioned this pull request Jul 4, 2023
Merged
@OrKoN
Copy link
Collaborator

OrKoN commented Jul 4, 2023

117.0.5870.0+ should have the fix.

@browser-automation-bot browser-automation-bot force-pushed the browser-automation-bot/update-browser-version branch from 3b78d43 to 13940b8 Compare July 4, 2023 15:31
@OrKoN OrKoN enabled auto-merge (squash) July 4, 2023 15:35
@thiagowfx thiagowfx disabled auto-merge July 4, 2023 16:32
@thiagowfx thiagowfx merged commit cb43a35 into main Jul 4, 2023
@thiagowfx thiagowfx deleted the browser-automation-bot/update-browser-version branch July 4, 2023 16:32
thiagowfx pushed a commit that referenced this pull request Jul 6, 2023
feat: addScriptToEvaluateOnNewDocument: run immediately (#919)
cfba71f 
Bug: #293
Doc:
[go/chrome-devtools:preload-script-world-name](http://go/chrome-devtools:preload-script-world-name)

## Tracking

- [x] Blocked on
#885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagowfx thiagowfx thiagowfx approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@browser-automation-bot @thiagowfx @OrKoN