Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: compare similarity of print to pdf output #912

Closed
wants to merge 1 commit into from
Closed

test: compare similarity of print to pdf output #912

wants to merge 1 commit into from

Conversation

thiagowfx
Copy link
Contributor

Bug: #518

@thiagowfx thiagowfx mentioned this pull request Jun 28, 2023
Open
8 tasks
@thiagowfx
Copy link
Contributor Author

I chose this approach as an AI from Bug: #518 as Page.navigate to application/pdf throws net::ERR_ABORTED.

@thiagowfx
Copy link
Contributor Author

E assert 0.1392931392931393 >= 0.95

Locally I consistently get >= 0.95, but apparently this approach is infeasible in CI.

@thiagowfx thiagowfx closed this Jun 28, 2023
@thiagowfx thiagowfx deleted the thiagowfx/print branch June 28, 2023 16:06
@thiagowfx thiagowfx mentioned this pull request Jun 28, 2023
Merged
1 task
thiagowfx pushed a commit that referenced this pull request Jun 29, 2023
test: print to pdf: convert to PNG and compare to golden (#914)
950554a 
This is a better approach than
#912.

## Tracking

- [x] distinguish headless x headful

Bug: #518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lightning00Blade Lightning00Blade Lightning00Blade approved these changes

@OrKoN OrKoN Awaiting requested review from OrKoN

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiagowfx @Lightning00Blade