test: print to pdf: convert to PNG and compare to golden #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagowfx
changed the title
8 tasks
thiagowfx
force-pushed
the
thiagowfx/print
branch
2 times, most recently
from
7190afa
to
653bdb8
Compare
|
This approach works well. We just need to find a way to distinguish headless from headful in pytest, so that we can check for an exception in the headless case. |
thiagowfx
force-pushed
the
thiagowfx/print
branch
from
4a65e52
to
5999ca5
Compare
|
Actually, I thought of a workaround: We could always try/catch, for the sake of silencing the error in headless. It's not very elegant, but it would work for the purposes of this test. |
OrKoN
approved these changes
Jun 29, 2023
thiagowfx
force-pushed
the
thiagowfx/print
branch
from
5999ca5
to
e3f0827
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a better approach than #912.
Tracking
Bug: #518