We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maxSigtermDelay
maxSigtermDelay should be pass as a duration to the cloud sql proxy container to be taken into account
maxSigtermDelay is configured as an environment variable with a number value type whereas the cloud sql proxy expects a duration (https://github.com/GoogleCloudPlatform/cloud-sql-proxy/blob/a2070bf1c6be9996945229b1b1e0a98ce9b36dd5/cmd/root.go#L468) A number without unit is considered as 0 for a duration (tested here: https://pkg.go.dev/time#ParseDuration).
n/a
I will propose a pull request to resolve this issue.
The text was updated successfully, but these errors were encountered:
fix: Add unit to CSQL_PROXY_MAX_SIGTERM_DELAY environment variable to…
92b603a
… be compatible with go duration Fixes GoogleCloudPlatform#610
c4eb455
hessjcg
Successfully merging a pull request may close this issue.
Expected Behavior
maxSigtermDelay
should be pass as a duration to the cloud sql proxy container to be taken into accountActual Behavior
maxSigtermDelay
is configured as an environment variable with a number value type whereas the cloud sql proxy expects a duration (https://github.com/GoogleCloudPlatform/cloud-sql-proxy/blob/a2070bf1c6be9996945229b1b1e0a98ce9b36dd5/cmd/root.go#L468)A number without unit is considered as 0 for a duration (tested here: https://pkg.go.dev/time#ParseDuration).
Steps to Reproduce the Problem
n/a
Specifications
I will propose a pull request to resolve this issue.
The text was updated successfully, but these errors were encountered: