Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add unit to CSQL_PROXY_MAX_SIGTERM_DELAY environment variable to… #611

Conversation

mlallaouret
Copy link
Contributor

… be compatible with go duration

Fixes #610

  • Tests pass
  • Appropriate changes to README are included in PR

@mlallaouret mlallaouret requested a review from a team as a code owner July 19, 2024 14:01
Copy link
Collaborator

@hessjcg hessjcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hessjcg hessjcg merged commit c4eb455 into GoogleCloudPlatform:main Jul 24, 2024
7 checks passed
@KeepItSimpleStupid KeepItSimpleStupid deleted the Fix_max_sigterm_delay_environment_variable_type branch July 24, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maxSigtermDelay is configured with wrong type when transformed to environment variable.
2 participants