New shutdown flag gives confusing error message #1885
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Bug Description
Using the new
--exit-zero-on-sigterm
does correctly exit with a 0, but gives you an incorrect error:So we're correctly getting a
0
, but equally it's logging an ERRORThe proxy has encountered a terminal error: SIGTERM signal received
which feels wrong.Structured logs shows the log level too:
In both shutdown scenarios, the message should be
2023/08/09 22:06:14 SIGTERM signal received. Shutting down...
Example code (or command)
No response
Stacktrace
No response
Steps to reproduce?
See above
Environment
./cloud-sql-proxy --version
): 2.6.0./cloud-sql-proxy --port 5432 INSTANCE_CONNECTION_NAME
): see aboveAdditional Details
No response
The text was updated successfully, but these errors were encountered: