Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the error message for zero on sigterm #1902

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

annafang-google
Copy link
Contributor

@annafang-google annafang-google commented Aug 11, 2023

Print shutdown message instead of error for the zero on sigterm case.

Fixes #1885

@annafang-google annafang-google requested a review from a team as a code owner August 11, 2023 14:03
@jackwotherspoon
Copy link
Collaborator

@annafang-google Friendly reminder: In the future you will want the PR title or commit to follow conventional commits for the check to be happy https://www.conventionalcommits.org/en/v1.0.0/

@annafang-google
Copy link
Contributor Author

@annafang-google Friendly reminder: In the future you will want the PR title or commit to follow conventional commits for the check to be happy https://www.conventionalcommits.org/en/v1.0.0/

Fixed. Thanks!

@jackwotherspoon jackwotherspoon changed the title Remove the error message for zero on sigterm (#1885) fix: remove the error message for zero on sigterm Aug 11, 2023
Copy link
Collaborator

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM

@annafang-google annafang-google merged commit 55f0f60 into main Aug 11, 2023
12 checks passed
@annafang-google annafang-google deleted the fix-shutdown-msg branch August 11, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New shutdown flag gives confusing error message
3 participants