Skip to content

Commit

Permalink
feat: Use AR instead of GCR on whoami example
Browse files Browse the repository at this point in the history
* Please see [Use AR instead of GCR for Deployments #209](#209).

    * AR = Artifact Registry

    * GCR = Google Container Registry

    * This pull-request for `whereami:v1.2.6`:

    * I'm replacing instances of the images' GCR URLs with the equivalent AR URLs.

      * `gcr.io/google-samples/whereami:v1.2.6` → `us-docker.pkg.dev/google-samples/containers/gke/whereami:v1.2.6`

So once merged, I would have to update the above tutorials via [this Google-internal content publisher](https://devsite.corp.google.com/publisher).

We can verify that the AR (replacement) images and GCR (replaced) images are equivalent like so:

    1. Pull the 2 images you want to compare:

```
docker image pull gcr.io/google-samples/whereami:v1.2.6
docker image pull us-docker.pkg.dev/google-samples/containers/gke/whereami:v1.2.6
```

    2. Inspecting both images:

```
docker image inspect gcr.io/google-samples/whereami:v1.2.6
docker image inspect us-docker.pkg.dev/google-samples/containers/gke/whereami:v1.2.6
```

    3. See that the [RootFS values match](https://stackoverflow.com/questions/46321878/how-to-verify-if-the-content-of-two-docker-images-is-exactly-the-same/46322160#46322160).
  • Loading branch information
irvifa committed Jan 1, 2022
1 parent 591b43f commit 72b9527
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion whereami/k8s-grpc/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ spec:
serviceAccountName: whereami-grpc-ksa
containers:
- name: whereami-grpc
image: gcr.io/google-samples/whereami:v1.2.6
image: us-docker.pkg.dev/google-samples/containers/gke/whereami:v1.2.6
ports:
- name: grpc
containerPort: 9090
Expand Down
2 changes: 1 addition & 1 deletion whereami/k8s/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ spec:
serviceAccountName: whereami-ksa
containers:
- name: whereami
image: gcr.io/google-samples/whereami:v1.2.6
image: us-docker.pkg.dev/google-samples/containers/gke/whereami:v1.2.6
ports:
- name: http
containerPort: 8080
Expand Down

0 comments on commit 72b9527

Please sign in to comment.